Pushdown simplest sorting for aggregate command
#2530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2530 +/- ##
==========================================
- Coverage 27.00% 26.97% -0.04%
==========================================
Files 405 405
Lines 20086 20110 +24
==========================================
Hits 5424 5424
- Misses 14091 14115 +24
Partials 571 571
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
@noisersup this pull request has merge conflicts. |
rumyantseva
changed the title
aggregate command aggregate command
rumyantseva
previously approved these changes
May 3, 2023
There was a problem hiding this comment.
I approve, but as I added some code here, more reviews are needed (@w84thesun @AlekSi)
rumyantseva
approved these changes
May 3, 2023
AlekSi
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #2438.
Let's review it after merging #2506.
From @rumyantseva: I tested it manually (
$match+$sort, only$sort,$sort+$match), and it works! Feel free to try it as well (don't forget to set--test-enable-sorting-pushdownflag).Readiness checklist
task all, and it passed.@FerretDB/core), Labels, Project and project's Sprint fields.