Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check test database name length in compat test setup #2527

Merged
merged 7 commits into from
May 1, 2023
Merged

Check test database name length in compat test setup #2527

merged 7 commits into from
May 1, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Apr 28, 2023 •
edited
Loading

Description

Closes #2065.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow self-assigned this Apr 28, 2023
@codecov
Copy link

codecov bot commented Apr 28, 2023 •
edited
Loading

Codecov Report

Merging #2527 (3d1e5c7) into main (6e0bd57) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2527   +/-   ##
=======================================
  Coverage   64.36%   64.36%           
=======================================
  Files         403      403           
  Lines       20031    20035    +4     
=======================================
+ Hits        12892    12896    +4     
  Misses       6204     6204           
  Partials      935      935
Impacted Files Coverage Δ
integration/setup/setup_compat.go 76.42% <100.00%> (+0.69%) ⬆️

... and 1 file with indirect coverage changes

Flag Coverage Δ
integration 57.18% <100.00%> (+<0.01%) ⬆️
mongodb 5.05% <0.00%> (-0.01%) ⬇️
pg 57.11% <100.00%> (+<0.01%) ⬆️
unit 25.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow added the code/chore Code maintenance improvements label Apr 28, 2023
@chilagrow chilagrow changed the title Fix invalid namespace error in integration test setup Check database name length in compat test setup Apr 28, 2023
@chilagrow chilagrow changed the title Check database name length in compat test setup Check test database name length in compat test setup Apr 28, 2023
@chilagrow chilagrow marked this pull request as ready for review April 28, 2023 07:46
@chilagrow chilagrow requested a review from a team as a code owner April 28, 2023 07:46
@chilagrow chilagrow requested review from AlekSi, w84thesun, a team, rumyantseva and noisersup April 28, 2023 07:46
@chilagrow chilagrow enabled auto-merge (squash) April 28, 2023 07:47
w84thesun
w84thesun approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice catch!

rumyantseva
rumyantseva approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the helpful fix!

@chilagrow chilagrow merged commit 93190b7 into FerretDB:main May 1, 2023
@AlekSi AlekSi added this to the v1.1.0 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun w84thesun approved these changes

@AlekSi AlekSi Awaiting requested review from AlekSi AlekSi is a code owner automatically assigned from FerretDB/leads

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Fix invalid namespace error
5 participants
@chilagrow @w84thesun @rumyantseva @noisersup @AlekSi