Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add identifying Arch Linux version in hostInfo command #2525

Merged
merged 3 commits into from
Apr 28, 2023
Merged

Add identifying Arch Linux version in hostInfo command #2525

merged 3 commits into from
Apr 28, 2023

Conversation

kropidlowsky
Copy link
Contributor

@kropidlowsky kropidlowsky commented Apr 27, 2023 •
edited
Loading

Description

Closes #2500.

Add identifying Arch Linux version in hostInfo command.
Most of Linux distributions contain /etc/os-release - the file used by FerretDB for hostInfo command.
However, Arch has /etc/arch-release instead of it. To keep functionality for most of Linux distributions the special Arch condition has been added.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@kropidlowsky kropidlowsky requested a review from a team as a code owner April 27, 2023 21:40
@codecov
Copy link

codecov bot commented Apr 27, 2023 •
edited
Loading

Codecov Report

Merging #2525 (91884fd) into main (f46ca4c) will decrease coverage by 37.54%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2525       +/-   ##
===========================================
- Coverage   64.34%   26.80%   -37.54%     
===========================================
  Files         403      403               
  Lines       19954    19956        +2     
===========================================
- Hits        12840     5350     -7490     
- Misses       6185    14041     +7856     
+ Partials      929      565      -364
Impacted Files Coverage Δ
internal/handlers/common/msg_hostinfo.go 0.00% <0.00%> (-72.92%) ⬇️

... and 128 files with indirect coverage changes

Flag Coverage Δ
integration 5.07% <0.00%> (-52.23%) ⬇️
mongodb 5.07% <0.00%> (-0.01%) ⬇️
pg ?
unit 25.41% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rumyantseva rumyantseva added the code/chore Code maintenance improvements label Apr 28, 2023
rumyantseva
rumyantseva approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks a lot for contributing!

@rumyantseva rumyantseva requested review from a team, w84thesun and noisersup April 28, 2023 08:23
@rumyantseva rumyantseva added code/enhancement Some user-visible feature could work better and removed code/chore Code maintenance improvements labels Apr 28, 2023
chilagrow
chilagrow approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for fixing this 😄

@rumyantseva rumyantseva enabled auto-merge (squash) April 28, 2023 08:25
w84thesun
w84thesun approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@rumyantseva rumyantseva merged commit 5e8b75e into FerretDB:main Apr 28, 2023
@AlekSi AlekSi added this to the v1.1.0 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun w84thesun approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@kropidlowsky kropidlowsky

Labels
code/enhancement Some user-visible feature could work better
Projects
Current Engineering
Archived in project
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Improve how we identify Linux version in hostInfo command
5 participants
@kropidlowsky @w84thesun @rumyantseva @chilagrow @AlekSi