Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update for conflicting dot notation paths #2521

Merged
merged 4 commits into from
Apr 27, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Apr 27, 2023

Description

Closes #1922.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/bug Some user-visible feature works incorrectly label Apr 27, 2023
@chilagrow chilagrow self-assigned this Apr 27, 2023
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #2521 (c226cb9) into main (4088762) will decrease coverage by 0.27%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2521      +/-   ##
==========================================
- Coverage   64.64%   64.38%   -0.27%     
==========================================
  Files         403      403              
  Lines       19976    19943      -33     
==========================================
- Hits        12914    12840      -74     
- Misses       6141     6174      +33     
- Partials      921      929       +8     
Impacted Files Coverage Δ
internal/handlers/common/update.go 85.91% <100.00%> (-3.06%) ⬇️

... and 4 files with indirect coverage changes

Flag Coverage Δ
integration 57.32% <100.00%> (-0.28%) ⬇️
mongodb 5.07% <0.00%> (+<0.01%) ⬆️
pg 57.25% <100.00%> (-0.28%) ⬇️
unit 25.43% <0.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow changed the title Update on conflicting path returns error Update on conflicting dot notation path returns error Apr 27, 2023
@chilagrow chilagrow marked this pull request as ready for review April 27, 2023 06:02
@chilagrow chilagrow requested a review from a team as a code owner April 27, 2023 06:02
@chilagrow chilagrow requested review from AlekSi and w84thesun April 27, 2023 06:03
@chilagrow chilagrow enabled auto-merge (squash) April 27, 2023 06:03
@chilagrow chilagrow requested review from a team, rumyantseva and noisersup April 27, 2023 06:03
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@chilagrow chilagrow merged commit c2c1d1f into FerretDB:main Apr 27, 2023
@AlekSi AlekSi added this to the v1.1.0 milestone May 9, 2023
@AlekSi AlekSi changed the title Update on conflicting dot notation path returns error Fix update for conflicting dot notation paths May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/bug Some user-visible feature works incorrectly
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Conflicting path should not be updated
4 participants