Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix collStats for Tigris #2520

Merged
merged 4 commits into from
Apr 27, 2023
Merged

Fix collStats for Tigris #2520

merged 4 commits into from
Apr 27, 2023

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented Apr 26, 2023 •
edited
Loading

Description

Closes #2505.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva added code/chore Code maintenance improvements no ci labels Apr 26, 2023
@rumyantseva rumyantseva self-assigned this Apr 26, 2023
@rumyantseva rumyantseva removed the no ci label Apr 27, 2023
@rumyantseva rumyantseva marked this pull request as ready for review April 27, 2023 11:27
@rumyantseva rumyantseva requested a review from a team as a code owner April 27, 2023 11:27
@rumyantseva rumyantseva requested review from AlekSi, chilagrow, a team, w84thesun and noisersup April 27, 2023 11:27
@codecov
Copy link

codecov bot commented Apr 27, 2023 •
edited
Loading

Codecov Report

Merging #2520 (316dd5a) into main (c2c1d1f) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2520      +/-   ##
==========================================
- Coverage   64.38%   64.30%   -0.09%     
==========================================
  Files         403      403              
  Lines       19943    19954      +11     
==========================================
- Hits        12840    12831       -9     
- Misses       6174     6195      +21     
+ Partials      929      928       -1
Impacted Files Coverage Δ
internal/handlers/tigris/msg_collstats.go 0.00% <0.00%> (ø)
internal/handlers/tigris/msg_dbstats.go 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

Flag Coverage Δ
integration 57.29% <0.00%> (-0.04%) ⬇️
mongodb 5.07% <0.00%> (-0.01%) ⬇️
pg 57.22% <0.00%> (-0.04%) ⬇️
unit 25.24% <0.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

w84thesun
w84thesun approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rumyantseva rumyantseva enabled auto-merge (squash) April 27, 2023 12:01
noisersup
noisersup approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rumyantseva rumyantseva merged commit eaaa9b5 into FerretDB:main Apr 27, 2023
@rumyantseva rumyantseva deleted the issue-2505-collstats-tigris branch April 27, 2023 12:55
@AlekSi AlekSi added this to the v1.1.0 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@w84thesun w84thesun w84thesun approved these changes

@AlekSi AlekSi Awaiting requested review from AlekSi AlekSi is a code owner automatically assigned from FerretDB/leads

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow is a code owner automatically assigned from FerretDB/leads

Assignees

@rumyantseva rumyantseva

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Fix collStats for Tigris
4 participants
@rumyantseva @w84thesun @noisersup @AlekSi