-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add InsertMany
benchmark
#2518
Add InsertMany
benchmark
#2518
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2518 +/- ##
=======================================
Coverage 27.02% 27.02%
=======================================
Files 400 400
Lines 19776 19776
=======================================
Hits 5345 5345
Misses 13865 13865
Partials 566 566
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried few things to make the results more stable (such as doing a sleep after recreating collection etc), although I didn't notice any improvement. I guess that's the topic for the future investigation :)
The benchmark looks good to me, left minor comment for consistency
Head branch was pushed to by a user without write access
Co-authored-by: Patryk Kwiatek <patryk@kwiatek.xyz>
Co-authored-by: Patryk Kwiatek <patryk@kwiatek.xyz>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
Description
Closes #2510.
Readiness checklist
task all
, and it passed.@FerretDB/core
), Labels, Project and project's Sprint fields.