Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return unsupported operator error for $ projection operator #2512

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

w84thesun
Copy link
Contributor

@w84thesun w84thesun commented Apr 25, 2023

Description

Closes #2492.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@w84thesun w84thesun added the code/bug Some user-visible feature works incorrectly label Apr 25, 2023
@w84thesun w84thesun self-assigned this Apr 25, 2023
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #2512 (5139518) into main (e44c4d3) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2512      +/-   ##
==========================================
- Coverage   64.76%   64.74%   -0.02%     
==========================================
  Files         399      399              
  Lines       19740    19746       +6     
==========================================
  Hits        12785    12785              
- Misses       6039     6044       +5     
- Partials      916      917       +1     
Impacted Files Coverage Δ
internal/handlers/common/projection.go 71.06% <0.00%> (-2.79%) ⬇️

... and 1 file with indirect coverage changes

Flag Coverage Δ
integration 57.95% <0.00%> (-0.02%) ⬇️
mongodb 5.12% <0.00%> (-0.07%) ⬇️
pg 57.87% <0.00%> (-0.02%) ⬇️
unit 25.34% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@w84thesun w84thesun requested review from a team, rumyantseva, chilagrow and noisersup April 25, 2023 14:56
@w84thesun w84thesun marked this pull request as ready for review April 25, 2023 14:56
@w84thesun w84thesun requested a review from a team as a code owner April 25, 2023 14:56
@w84thesun w84thesun enabled auto-merge (squash) April 25, 2023 14:56
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@w84thesun w84thesun merged commit 02eb177 into FerretDB:main Apr 25, 2023
@w84thesun w84thesun deleted the issue-2492-fix-projection branch April 25, 2023 16:24
@rumyantseva rumyantseva added code/chore Code maintenance improvements and removed code/bug Some user-visible feature works incorrectly labels Apr 26, 2023
@AlekSi AlekSi added this to the v1.1.0 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Return an error for $ projection operator
4 participants