Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blog file names to match with slug #2497

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Apr 21, 2023

Description

Closes #2432.

The linter added in #2459 discovered that we have slug and filename mismatch, see
https://github.com/FerretDB/FerretDB/actions/runs/4761652987/jobs/8463755846?pr=2459

Let's fix the file name to match with slug. We don't want to modify slug because we don't want URL to change and also for SEO purpose.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow self-assigned this Apr 21, 2023
@chilagrow chilagrow changed the title Update blog file name to match with slug Update blog file names to match with slug Apr 21, 2023
@chilagrow chilagrow added the code/chore Code maintenance improvements label Apr 21, 2023
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #2497 (750a753) into main (a7e36aa) will decrease coverage by 38.10%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2497       +/-   ##
===========================================
- Coverage   64.80%   26.70%   -38.10%     
===========================================
  Files         399      399               
  Lines       19714    19714               
===========================================
- Hits        12775     5265     -7510     
- Misses       6027    13892     +7865     
+ Partials      912      557      -355     

see 128 files with indirect coverage changes

Flag Coverage Δ
integration 5.03% <ø> (-52.96%) ⬇️
mongodb 5.03% <ø> (ø)
pg ?
unit 25.35% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow requested review from a team, w84thesun, rumyantseva and noisersup April 21, 2023 09:31
@chilagrow chilagrow marked this pull request as ready for review April 21, 2023 09:31
@chilagrow chilagrow enabled auto-merge (squash) April 21, 2023 09:31
@chilagrow chilagrow added trust PRs that can access Actions secrets do not merge PRs that should not be merged no ci blog/engineering Engineering blog posts and removed no ci labels Apr 24, 2023
@mergify mergify bot requested review from a team April 24, 2023 03:19
@mergify
Copy link
Contributor

mergify bot commented Apr 24, 2023

Engineering blog posts should be reviewed by other engineers and @Fashander.

@chilagrow chilagrow added no ci and removed no ci labels Apr 24, 2023
@chilagrow chilagrow removed the trust PRs that can access Actions secrets label Apr 24, 2023
@chilagrow chilagrow removed the do not merge PRs that should not be merged label Apr 24, 2023
@chilagrow chilagrow merged commit 1875ff9 into FerretDB:main Apr 24, 2023
@AlekSi AlekSi added this to the v1.1.0 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blog/engineering Engineering blog posts code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add linter for checking blog posts
6 participants