Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use update_available from Beacon #2496

Merged
merged 8 commits into from
Apr 25, 2023
Merged

Use update_available from Beacon #2496

merged 8 commits into from
Apr 25, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Apr 21, 2023 •
edited
Loading

Description

Closes #1751.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow self-assigned this Apr 21, 2023
@codecov
Copy link

codecov bot commented Apr 21, 2023 •
edited
Loading

Codecov Report

Merging #2496 (7c19db2) into main (02eb177) will increase coverage by 0.33%.
The diff coverage is 85.71%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2496      +/-   ##
==========================================
+ Coverage   26.73%   27.06%   +0.33%     
==========================================
  Files         399      399              
  Lines       19746    19747       +1     
==========================================
+ Hits         5279     5345      +66     
+ Misses      13908    13836      -72     
- Partials      559      566       +7
Impacted Files Coverage Δ
internal/util/telemetry/reporter.go 43.02% <76.92%> (+37.10%) ⬆️
internal/util/state/state.go 88.57% <100.00%> (+10.19%) ⬆️
Flag Coverage Δ
integration 5.12% <0.00%> (+<0.01%) ⬆️
mongodb 5.12% <0.00%> (+<0.01%) ⬆️
unit 25.67% <85.71%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow changed the title Notifying new version uses update_available from telemetry Notifying a new version uses update_available from telemetry Apr 21, 2023
@chilagrow chilagrow changed the title Notifying a new version uses update_available from telemetry New version notification uses update_available from telemetry Apr 24, 2023
@chilagrow chilagrow added code/enhancement Some user-visible feature could work better code/chore Code maintenance improvements and removed code/enhancement Some user-visible feature could work better labels Apr 24, 2023
@chilagrow chilagrow requested review from a team, w84thesun, rumyantseva and noisersup April 24, 2023 08:24
@chilagrow chilagrow marked this pull request as ready for review April 24, 2023 08:24
@chilagrow chilagrow requested a review from a team as a code owner April 24, 2023 08:24
@chilagrow chilagrow enabled auto-merge (squash) April 24, 2023 08:24
w84thesun
w84thesun previously approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

rumyantseva
rumyantseva suggested changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks good to me, but I don't see that the test checks the necessary logic.

internal/util/telemetry/reporter_test.go Show resolved Hide resolved
internal/util/telemetry/reporter_test.go Outdated Show resolved Hide resolved
rumyantseva
rumyantseva approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

w84thesun
w84thesun approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

noisersup
noisersup approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

internal/util/telemetry/reporter_test.go Outdated Show resolved Hide resolved
@chilagrow chilagrow merged commit ce28270 into FerretDB:main Apr 25, 2023
@AlekSi AlekSi changed the title New version notification uses update_available from telemetry Use update_available from Beacon May 1, 2023
@AlekSi
Copy link
Member

AlekSi commented May 1, 2023

I ensured that PR title is good enough for the changelog.

Please check what we have in the changelog now: https://github.com/FerretDB/FerretDB/blob/main/CHANGELOG.md

@chilagrow
Copy link
Member Author

chilagrow commented May 2, 2023 •
edited
Loading

I ensured that PR title is good enough for the changelog.

Please check what we have in the changelog now: https://github.com/FerretDB/FerretDB/blob/main/CHANGELOG.md

It can be better 😓, is manually changing change log a thing once PR is merged?

@AlekSi AlekSi added this to the v1.1.0 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun w84thesun approved these changes

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Simplify and test notifications about newer versions
5 participants
@chilagrow @AlekSi @w84thesun @rumyantseva @noisersup