-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document createIndexes
, listIndexes
, and dropIndexes
commands
#2488
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2488 +/- ##
=======================================
Coverage 65.15% 65.15%
=======================================
Files 410 410
Lines 20071 20071
=======================================
Hits 13077 13077
Misses 6055 6055
Partials 939 939 see 1 file with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
createIndexes
, listIndexes
, and dropIndexes
createIndexes
, listIndexes
, and dropIndexes
commands
c63335a
to
b65445d
Compare
Co-authored-by: Chi Fujii <chi.fujii@ferretdb.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested a few things and asked a few questions.
There is one thing to clarify: commands and methods/wrappers/handers are not the same.
Commands are on the server (FerretDB) side, and methods/wrappers/handers are on the client/driver side.
There could be a few methods to call the same command. For example, both dropIndex()
and dropIndexes()
methods call dropIndexes()
command.
I find this mixture of methods and commands a bit inconsistent, but probably this is how we use in the other parts of our docs too...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@AlekSi PTAL |
Description
Closes #2271.
Readiness checklist
task all
, and it passed.@FerretDB/core
), Labels, Project and project's Sprint fields.