Add a YAML formatter #2485
Merged
Add a YAML formatter #2485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Closed
rumyantseva
suggested changes
Apr 21, 2023
There was a problem hiding this comment.
The formatter looks good to me, but I suggest we use docker compose for the task, so it's consistent with the other tasks and uses the same dedicated configuration.
I also changed the title of the PR, so it contains a brief description of changes for the changelog.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2485 +/- ##
==========================================
+ Coverage 25.36% 26.75% +1.39%
==========================================
Files 391 403 +12
Lines 18888 19976 +1088
==========================================
+ Hits 4790 5345 +555
- Misses 13561 14065 +504
- Partials 537 566 +29 see 18 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
rumyantseva
reviewed
Apr 21, 2023
rumyantseva
approved these changes
Apr 24, 2023
chilagrow
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1301 .
Readiness checklist
task all, and it passed.@FerretDB/core), Labels, Project and project's Sprint fields.