-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable debugging tracing of SQL queries #2467
Enable debugging tracing of SQL queries #2467
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2467 +/- ##
===========================================
- Coverage 64.69% 26.53% -38.16%
===========================================
Files 398 399 +1
Lines 19681 19714 +33
===========================================
- Hits 12733 5232 -7501
- Misses 6033 13925 +7892
+ Partials 915 557 -358
... and 128 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for sending the PR!
Yes, this approach is something we want to start from. Of course, we want to add an ability to trace requests, so those pgdb
spans will become parts of some other spans. But it's for a separate issue. For now, we just want to start seeing at least some data :)
I added a couple of comments about TraceQueryStart
and TraceQueryEnd
implementation - let's add some data as span attributes, so we can see some actual info about the queries in Jaeger.
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing! I tried everything locally, I think it's a great way to start collecting traces.
Description
Closes #2389.
I had a quick go at trying to resolve #2389. Is this the approach you would like to take? I can see the spans in Jaeger, but, afaict, they are not part of anything else.
Readiness checklist
task all
, and it passed.@FerretDB/core
), Labels, Project and project's Sprint fields.