Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for CockroachDB issue #2464

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Add workaround for CockroachDB issue #2464

merged 3 commits into from
Apr 18, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Apr 18, 2023

Description

Refs cockroachdb/cockroach#101715.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Apr 18, 2023
@AlekSi AlekSi added this to the v1.1.0 milestone Apr 18, 2023
@AlekSi AlekSi self-assigned this Apr 18, 2023
@AlekSi AlekSi requested a review from a team as a code owner April 18, 2023 08:08
@AlekSi AlekSi requested review from w84thesun and rumyantseva April 18, 2023 08:08
@AlekSi AlekSi enabled auto-merge (squash) April 18, 2023 08:08
@AlekSi AlekSi requested review from a team, chilagrow and noisersup April 18, 2023 08:08
noisersup
noisersup previously approved these changes Apr 18, 2023
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, linters need to be addressed

@AlekSi
Copy link
Member Author

AlekSi commented Apr 18, 2023

oops!

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #2464 (e8355bb) into main (ec496f0) will decrease coverage by 0.16%.
The diff coverage is 55.55%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2464      +/-   ##
==========================================
- Coverage   26.79%   26.63%   -0.16%     
==========================================
  Files         394      394              
  Lines       19339    19346       +7     
==========================================
- Hits         5182     5153      -29     
- Misses      13602    13637      +35     
- Partials      555      556       +1     
Impacted Files Coverage Δ
internal/handlers/pg/pgdb/pool.go 40.90% <55.55%> (+0.77%) ⬆️

... and 6 files with indirect coverage changes

Flag Coverage Δ
integration 4.70% <0.00%> (-0.01%) ⬇️
mongodb 4.70% <0.00%> (-0.01%) ⬇️
unit 25.28% <55.55%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi requested a review from noisersup April 18, 2023 08:18
@AlekSi AlekSi requested a review from a team April 18, 2023 08:18
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@AlekSi AlekSi merged commit fa07a77 into FerretDB:main Apr 18, 2023
@AlekSi AlekSi deleted the cockroach branch April 18, 2023 09:09
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants