Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor aggregation #2463

Merged
merged 9 commits into from
Apr 19, 2023
Merged

Refactor aggregation #2463

merged 9 commits into from
Apr 19, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Apr 18, 2023 •
edited
Loading

Description

Closes #2356.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow self-assigned this Apr 18, 2023
@chilagrow chilagrow added the code/chore Code maintenance improvements label Apr 18, 2023
@codecov
Copy link

codecov bot commented Apr 18, 2023 •
edited
Loading

Codecov Report

Merging #2463 (bdf0f4e) into main (cb6bf40) will decrease coverage by 37.65%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2463       +/-   ##
===========================================
- Coverage   64.32%   26.67%   -37.65%     
===========================================
  Files         397      397               
  Lines       19566    19566               
===========================================
- Hits        12586     5220     -7366     
- Misses       6066    13788     +7722     
+ Partials      914      558      -356
Impacted Files Coverage Δ
...al/handlers/common/aggregations/operators/count.go 0.00% <0.00%> (ø)
...l/handlers/common/aggregations/operators/number.go 0.00% <ø> (ø)
...rnal/handlers/common/aggregations/operators/sum.go 0.00% <0.00%> (ø)
...l/handlers/common/aggregations/stages/collstats.go 0.00% <0.00%> (ø)
...ernal/handlers/common/aggregations/stages/count.go 0.00% <0.00%> (ø)
...ernal/handlers/common/aggregations/stages/group.go 0.00% <0.00%> (ø)
...ernal/handlers/common/aggregations/stages/limit.go 0.00% <ø> (ø)
...ernal/handlers/common/aggregations/stages/match.go 0.00% <ø> (ø)
...al/handlers/common/aggregations/stages/pushdown.go 0.00% <ø> (ø)
...ternal/handlers/common/aggregations/stages/skip.go 0.00% <ø> (ø)
... and 8 more

... and 111 files with indirect coverage changes

Flag Coverage Δ
integration 5.03% <0.00%> (-52.44%) ⬇️
mongodb 5.03% <0.00%> (ø)
pg ?
unit 25.30% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@mergify
Copy link
Contributor

mergify bot commented Apr 18, 2023

@chilagrow this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Apr 18, 2023
@mergify mergify bot removed the conflict PRs that have merge conflicts label Apr 18, 2023
@chilagrow chilagrow requested review from a team, w84thesun, rumyantseva and noisersup April 18, 2023 08:59
@chilagrow chilagrow marked this pull request as ready for review April 18, 2023 08:59
@chilagrow chilagrow requested a review from a team as a code owner April 18, 2023 08:59
@chilagrow chilagrow enabled auto-merge (squash) April 18, 2023 08:59
w84thesun
w84thesun reviewed Apr 18, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, asked a couple of questions.

internal/handlers/common/aggregations/operators/operators.go Outdated Show resolved Hide resolved
internal/handlers/common/aggregations/number.go Outdated Show resolved Hide resolved
rumyantseva
rumyantseva reviewed Apr 18, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job clarifying what is what!

I left a few questions/comments about consistency.

internal/handlers/common/aggregations/stages/collstats.go Show resolved Hide resolved
internal/handlers/common/aggregations/stages/group.go Show resolved Hide resolved
internal/handlers/common/aggregations/stages/statistics.go Show resolved Hide resolved
internal/handlers/common/aggregations/number.go Outdated Show resolved Hide resolved
w84thesun
w84thesun approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

rumyantseva
rumyantseva approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chilagrow chilagrow merged commit c2a90d3 into FerretDB:main Apr 19, 2023
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
@chilagrow @fenogentov
Refactor aggregation (FerretDB#2463)
11b3f41
@AlekSi AlekSi added this to the v1.1.0 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun w84thesun approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Refactor common/aggregation
4 participants
@chilagrow @w84thesun @rumyantseva @AlekSi