Handle create and drop commands in Hana handler
#2458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
polyal
changed the title
9 tasks
|
@polyal Please sign our CLA by clicking a button in that comment: #2458 (comment) |
AlekSi
changed the title
create and drop commands in Hana handler
AlekSi
reviewed
Apr 18, 2023
AlekSi
requested review from
a team,
chilagrow,
w84thesun,
rumyantseva and
noisersup
AlekSi
previously approved these changes
Apr 21, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2458 +/- ##
==========================================
+ Coverage 25.70% 26.64% +0.93%
==========================================
Files 388 403 +15
Lines 18688 19955 +1267
==========================================
+ Hits 4804 5317 +513
- Misses 13347 14073 +726
- Partials 537 565 +28
... and 24 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
chilagrow
reviewed
Apr 24, 2023
There was a problem hiding this comment.
Great work.
I'm seeing linter warning, could you fix that please 🤗
bin/task lint
task: [lint] bin/golangci-lint run --config=.golangci.yml
Error: internal/handlers/hana/hanadb/hanadb.go:58:96: Comment should end in a period (godot)
task: Failed to run task "lint": exit status 1
task: Failed to run task "lint": exit status 1
// Returns one of the errors above or the original error if the formatted version doesn't exist
^
Error: Process completed with exit code 201.
auto-merge was automatically disabled
April 24, 2023 16:33
Head branch was pushed to by a user without write access
chilagrow
approved these changes
Apr 25, 2023
noisersup
approved these changes
Apr 25, 2023
rumyantseva
added
the
code/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #{issue_number}.
Readiness checklist
task all, and it passed.@FerretDB/core), Labels, Project and project's Sprint fields.