Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak documentation #2452

Merged
merged 11 commits into from
Apr 19, 2023
Merged

Tweak documentation #2452

merged 11 commits into from
Apr 19, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Apr 17, 2023 •
edited
Loading

Description

Just add a few TODO items and improve our guidelines.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets labels Apr 17, 2023
@AlekSi AlekSi added this to the v1.1.0 milestone Apr 17, 2023
@AlekSi AlekSi requested a review from ptrfarkas as a code owner April 17, 2023 16:19
@AlekSi AlekSi self-assigned this Apr 17, 2023
@AlekSi AlekSi temporarily deployed to cloudflare-dev April 17, 2023 16:19 — with GitHub Actions Inactive
@AlekSi AlekSi enabled auto-merge (squash) April 17, 2023 16:19
@AlekSi AlekSi requested a review from Fashander April 17, 2023 16:19
@codecov
Copy link

codecov bot commented Apr 17, 2023 •
edited
Loading

Codecov Report

Merging #2452 (07c0d6a) into main (fa07a77) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2452      +/-   ##
==========================================
+ Coverage   64.44%   64.46%   +0.01%     
==========================================
  Files         394      394              
  Lines       19346    19346              
==========================================
+ Hits        12468    12471       +3     
+ Misses       5973     5971       -2     
+ Partials      905      904       -1

see 2 files with indirect coverage changes

Flag Coverage Δ
integration 57.49% <ø> (+0.01%) ⬆️
mongodb 4.70% <ø> (ø)
pg 57.42% <ø> (+0.01%) ⬆️
unit 25.48% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi temporarily deployed to cloudflare-dev April 17, 2023 18:16 — with GitHub Actions Inactive
@AlekSi AlekSi temporarily deployed to cloudflare-dev April 17, 2023 18:20 — with GitHub Actions Inactive
@AlekSi AlekSi temporarily deployed to cloudflare-dev April 18, 2023 06:24 — with GitHub Actions Inactive
@AlekSi AlekSi requested review from a team, rumyantseva and chilagrow April 18, 2023 06:24
@AlekSi AlekSi marked this pull request as draft April 18, 2023 08:12
auto-merge was automatically disabled April 18, 2023 08:12

Pull request was converted to draft

@AlekSi AlekSi removed request for a team, rumyantseva, chilagrow and Fashander April 18, 2023 08:13
@AlekSi AlekSi temporarily deployed to cloudflare-dev April 18, 2023 12:58 — with GitHub Actions Inactive
@AlekSi AlekSi marked this pull request as ready for review April 18, 2023 12:58
@AlekSi AlekSi removed documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets labels Apr 18, 2023
@AlekSi AlekSi requested review from a team, w84thesun, rumyantseva, chilagrow and noisersup April 18, 2023 12:58
@AlekSi AlekSi added the code/chore Code maintenance improvements label Apr 18, 2023
@AlekSi AlekSi changed the title Add issues links Small documentation tweaks Apr 18, 2023
@AlekSi AlekSi enabled auto-merge (squash) April 18, 2023 12:59
noisersup
noisersup approved these changes Apr 18, 2023
View reviewed changes
.github/PROCESS.md Show resolved Hide resolved
w84thesun
w84thesun approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

rumyantseva
rumyantseva approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi added the no ci label Apr 19, 2023
@AlekSi AlekSi disabled auto-merge April 19, 2023 09:56
@AlekSi AlekSi merged commit 3f0e290 into FerretDB:main Apr 19, 2023
@AlekSi AlekSi deleted the todos branch April 19, 2023 09:56
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
@AlekSi @fenogentov
Small documentation tweaks (FerretDB#2452)
e1013cc
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
@AlekSi @fenogentov
Small documentation tweaks (FerretDB#2452)
1ad40bb
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
@AlekSi @fenogentov
Small documentation tweaks (FerretDB#2452)
1fd8c22
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
@AlekSi @fenogentov
Small documentation tweaks (FerretDB#2452)
57ad088
@AlekSi AlekSi changed the title Small documentation tweaks Tweak documentation May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@Fashander Fashander Fashander approved these changes

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun w84thesun approved these changes

@ptrfarkas ptrfarkas Awaiting requested review from ptrfarkas ptrfarkas is a code owner

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@AlekSi @w84thesun @rumyantseva @chilagrow @Fashander @noisersup