Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to pgx/v5 #2439

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Migrate to pgx/v5 #2439

merged 2 commits into from
Apr 17, 2023

Conversation

craigpastro
Copy link
Contributor

@craigpastro craigpastro commented Apr 16, 2023 •
edited by AlekSi
Loading

Description

Closes #1717.

Update pgx to v5. It was pretty straightforward, except for the changes in internal/handlers/pg/pgdb/pool.go. I am not sure how you would like to handle those as there is no longer a config.ConnConfig.Logger.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@CLAassistant
Copy link

CLAassistant commented Apr 16, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@craigpastro craigpastro marked this pull request as ready for review April 16, 2023 20:21
@craigpastro craigpastro requested review from AlekSi and a team as code owners April 16, 2023 20:21
@AlekSi
Copy link
Member

AlekSi commented Apr 17, 2023

@craigpastro Please click CLA button at #2439 (comment)

@AlekSi AlekSi added deps PRs that update dependencies code/chore Code maintenance improvements labels Apr 17, 2023
@AlekSi AlekSi self-assigned this Apr 17, 2023
@AlekSi AlekSi added this to the v1.1.0 milestone Apr 17, 2023
@codecov
Copy link

codecov bot commented Apr 17, 2023 •
edited
Loading

Codecov Report

Merging #2439 (e667ffe) into main (4d47717) will decrease coverage by 0.07%.
The diff coverage is 87.50%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2439      +/-   ##
==========================================
- Coverage   64.39%   64.33%   -0.07%     
==========================================
  Files         392      392              
  Lines       19251    19251              
==========================================
- Hits        12397    12385      -12     
- Misses       5955     5963       +8     
- Partials      899      903       +4
Impacted Files Coverage Δ
ferretdb/ferretdb.go 83.00% <ø> (ø)
internal/handlers/pg/msg_aggregate.go 79.90% <ø> (ø)
internal/handlers/pg/msg_count.go 61.53% <ø> (ø)
internal/handlers/pg/msg_create.go 72.72% <ø> (ø)
internal/handlers/pg/msg_createindexes.go 76.05% <ø> (ø)
internal/handlers/pg/msg_datasize.go 69.64% <ø> (ø)
internal/handlers/pg/msg_delete.go 68.33% <ø> (ø)
internal/handlers/pg/msg_distinct.go 65.90% <ø> (ø)
internal/handlers/pg/msg_drop.go 65.00% <ø> (ø)
internal/handlers/pg/msg_dropdatabase.go 67.64% <ø> (ø)
... and 21 more

... and 2 files with indirect coverage changes

Flag Coverage Δ
integration 57.31% <87.50%> (-0.07%) ⬇️
mongodb 4.72% <0.00%> (ø)
pg 57.24% <87.50%> (-0.07%) ⬇️
unit 25.59% <81.25%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

AlekSi
AlekSi approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, just great!

@AlekSi
Copy link
Member

AlekSi commented Apr 17, 2023

I am not sure how you would like to handle those as there is no longer a config.ConnConfig.Logger.

That looks great to me

@AlekSi
Copy link
Member

AlekSi commented Apr 17, 2023

@chilagrow PTAL

@AlekSi AlekSi changed the title Migrate to pgx/v5 Migrate to pgx/v5 Apr 17, 2023
@AlekSi AlekSi enabled auto-merge (squash) April 17, 2023 05:58
chilagrow
chilagrow approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks for updating linter as well 🤗

@AlekSi AlekSi merged commit d7e609c into FerretDB:main Apr 17, 2023
@craigpastro craigpastro deleted the migrate-to-pgx-v5 branch April 17, 2023 16:04
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 17, 2023
@fenogentov
Migrate to pgx/v5 (FerretDB#2439)
0656ccf 
Closes FerretDB#1717.
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
@fenogentov
Migrate to pgx/v5 (FerretDB#2439)
a9673ed 
Closes FerretDB#1717.
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
@fenogentov
Migrate to pgx/v5 (FerretDB#2439)
efcc60d 
Closes FerretDB#1717.
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
@fenogentov
Migrate to pgx/v5 (FerretDB#2439)
c7336c7 
Closes FerretDB#1717.
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
@fenogentov
Migrate to pgx/v5 (FerretDB#2439)
d503d04 
Closes FerretDB#1717.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@AlekSi AlekSi AlekSi approved these changes

Assignees

@AlekSi AlekSi

@craigpastro craigpastro

Labels
code/chore Code maintenance improvements deps PRs that update dependencies
Projects
Current Engineering
Archived in project
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Migrate to pgx/v5
4 participants
@craigpastro @CLAassistant @AlekSi @chilagrow