Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename testing flag #2437

Merged
merged 9 commits into from
Apr 17, 2023
Merged

Rename testing flag #2437

merged 9 commits into from
Apr 17, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Apr 16, 2023 •
edited
Loading

Description

For consistency with a future flag.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Apr 16, 2023
@AlekSi AlekSi added this to the v1.1.0 milestone Apr 16, 2023
@AlekSi AlekSi self-assigned this Apr 16, 2023
@codecov
Copy link

codecov bot commented Apr 16, 2023 •
edited
Loading

Codecov Report

Merging #2437 (c226771) into main (0a3a45c) will increase coverage by 0.19%.
The diff coverage is 14.81%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2437      +/-   ##
==========================================
+ Coverage   26.71%   26.91%   +0.19%     
==========================================
  Files         393      393              
  Lines       19289    19291       +2     
==========================================
+ Hits         5154     5192      +38     
+ Misses      13581    13545      -36     
  Partials      554      554
Impacted Files Coverage Δ
integration/setup/listener.go 0.00% <0.00%> (ø)
integration/setup/setup.go 73.72% <ø> (ø)
integration/setup/test_helpers.go 81.48% <0.00%> (ø)
internal/handlers/pg/msg_count.go 0.00% <0.00%> (ø)
internal/handlers/pg/msg_delete.go 0.00% <0.00%> (ø)
internal/handlers/pg/msg_distinct.go 0.00% <0.00%> (ø)
internal/handlers/pg/msg_explain.go 0.00% <0.00%> (ø)
internal/handlers/pg/msg_find.go 0.00% <0.00%> (ø)
internal/handlers/pg/msg_findandmodify.go 0.00% <0.00%> (ø)
internal/handlers/pg/msg_update.go 0.00% <0.00%> (ø)
... and 12 more

... and 6 files with indirect coverage changes

Flag Coverage Δ
integration 4.71% <0.00%> (-0.01%) ⬇️
mongodb 4.71% <0.00%> (-0.01%) ⬇️
unit 25.57% <16.66%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi marked this pull request as ready for review April 17, 2023 04:20
@AlekSi AlekSi requested a review from a team as a code owner April 17, 2023 04:20
@AlekSi AlekSi enabled auto-merge (squash) April 17, 2023 04:20
@AlekSi AlekSi requested review from a team and noisersup April 17, 2023 04:20
@AlekSi AlekSi merged commit b4f6f7e into FerretDB:main Apr 17, 2023
@AlekSi AlekSi deleted the rename-flag branch April 17, 2023 18:10
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 17, 2023
@AlekSi @fenogentov
Rename testing flag (FerretDB#2437)
22545b5
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
@AlekSi @fenogentov
Rename testing flag (FerretDB#2437)
7601cb8
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
@AlekSi @fenogentov
Rename testing flag (FerretDB#2437)
51c7b93
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
@AlekSi @fenogentov
Rename testing flag (FerretDB#2437)
1ab86f8
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
@AlekSi @fenogentov
Rename testing flag (FerretDB#2437)
54455db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@w84thesun w84thesun w84thesun approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @w84thesun @chilagrow