Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement blog posts previews #2433

Merged
merged 15 commits into from
Apr 18, 2023
Merged

Implement blog posts previews #2433

merged 15 commits into from
Apr 18, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Apr 14, 2023 •
edited
Loading

Description

Closes FerretDB/engineering#57.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@noisersup noisersup changed the title wip Implement blog posts previews Apr 14, 2023
@noisersup noisersup added documentation Something user-visible is badly or not documented blog/engineering Engineering blog posts labels Apr 14, 2023
@codecov
Copy link

codecov bot commented Apr 14, 2023 •
edited
Loading

Codecov Report

Merging #2433 (b6c9fe5) into main (e3c6cf8) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2433   +/-   ##
=======================================
  Coverage   26.67%   26.67%           
=======================================
  Files         395      395           
  Lines       19439    19439           
=======================================
  Hits         5186     5186           
  Misses      13697    13697           
  Partials      556      556
Flag Coverage Δ
integration 4.68% <ø> (ø)
mongodb 4.68% <ø> (ø)
unit 25.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mergify
Copy link
Contributor

mergify bot commented Apr 14, 2023

Engineering blog posts should be reviewed by other engineers and @Fashander.

@mergify
Copy link
Contributor

mergify bot commented Apr 14, 2023

@noisersup this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Apr 14, 2023
@noisersup noisersup added the trust PRs that can access Actions secrets label Apr 14, 2023
@AlekSi AlekSi removed the blog/engineering Engineering blog posts label Apr 15, 2023
@AlekSi AlekSi temporarily deployed to cloudflare-dev April 15, 2023 16:59 — with GitHub Actions Inactive
@AlekSi AlekSi added this to the v1.1.0 milestone Apr 15, 2023
@mergify mergify bot removed the conflict PRs that have merge conflicts label Apr 17, 2023
@mergify mergify bot temporarily deployed to cloudflare-dev April 17, 2023 07:47 Inactive
@noisersup noisersup temporarily deployed to cloudflare-dev April 17, 2023 09:12 — with GitHub Actions Inactive
@noisersup noisersup added blog/engineering Engineering blog posts and removed documentation Something user-visible is badly or not documented labels Apr 17, 2023
@mergify
Copy link
Contributor

mergify bot commented Apr 17, 2023

Engineering blog posts should be reviewed by other engineers and @Fashander.

@AlekSi AlekSi removed the blog/engineering Engineering blog posts label Apr 17, 2023
@noisersup noisersup marked this pull request as ready for review April 18, 2023 12:08
@noisersup noisersup removed trust PRs that can access Actions secrets no ci labels Apr 18, 2023
@noisersup noisersup added the code/chore Code maintenance improvements label Apr 18, 2023
AlekSi
AlekSi previously approved these changes Apr 18, 2023
View reviewed changes
.github/workflows/webpage-preview.yml Outdated Show resolved Hide resolved
@noisersup noisersup requested a review from AlekSi April 18, 2023 12:23
@noisersup noisersup enabled auto-merge (squash) April 18, 2023 12:23
w84thesun
w84thesun approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

rumyantseva
rumyantseva approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@noisersup noisersup merged commit f1b35e1 into FerretDB:main Apr 18, 2023
@noisersup noisersup deleted the blog-preview-deployment branch April 18, 2023 13:47
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
@noisersup @fenogentov
Implement blog posts previews (FerretDB#2433)
cdfae4e
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
@noisersup @fenogentov
Implement blog posts previews (FerretDB#2433)
fe2359c
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
@noisersup @fenogentov
Implement blog posts previews (FerretDB#2433)
df5a335
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
@noisersup @fenogentov
Implement blog posts previews (FerretDB#2433)
0f8c74d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun w84thesun approved these changes

@AlekSi AlekSi AlekSi approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow

Assignees

@noisersup noisersup

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@noisersup @AlekSi @w84thesun @rumyantseva