Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SchemaStats to return correct data #2426

Merged
merged 27 commits into from
Apr 18, 2023
Merged

Fix SchemaStats to return correct data #2426

merged 27 commits into from
Apr 18, 2023

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented Apr 13, 2023 •
edited
Loading

Description

Closes #1346.
Closes #1068.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva self-assigned this Apr 13, 2023
@rumyantseva rumyantseva added code/enhancement Some user-visible feature could work better no ci labels Apr 13, 2023
@codecov
Copy link

codecov bot commented Apr 13, 2023 •
edited
Loading

Codecov Report

Merging #2426 (67e107e) into main (fa07a77) will decrease coverage by 0.03%.
The diff coverage is 83.82%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2426      +/-   ##
==========================================
- Coverage   64.44%   64.42%   -0.03%     
==========================================
  Files         394      395       +1     
  Lines       19346    19439      +93     
==========================================
+ Hits        12468    12524      +56     
- Misses       5973     6002      +29     
- Partials      905      913       +8
Impacted Files Coverage Δ
internal/handlers/pg/pgdb/pool.go 57.79% <ø> (-12.34%) ⬇️
internal/handlers/pg/pgdb/stats.go 77.66% <77.66%> (ø)
internal/handlers/pg/msg_collstats.go 69.69% <86.20%> (-2.31%) ⬇️
internal/handlers/pg/msg_serverstatus.go 72.72% <87.50%> (+4.87%) ⬆️
internal/handlers/pg/msg_aggregate.go 81.39% <88.46%> (+1.49%) ⬆️
internal/handlers/pg/msg_datasize.go 67.85% <91.66%> (-1.79%) ⬇️
internal/handlers/pg/msg_dbstats.go 73.68% <96.15%> (+4.29%) ⬆️

... and 3 files with indirect coverage changes

Flag Coverage Δ
integration 57.58% <83.82%> (+0.10%) ⬆️
mongodb 4.68% <0.00%> (-0.03%) ⬇️
pg 57.50% <83.82%> (+0.10%) ⬆️
unit 25.16% <0.00%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@mergify
Copy link
Contributor

mergify bot commented Apr 17, 2023

@rumyantseva this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Apr 17, 2023
@mergify mergify bot removed the conflict PRs that have merge conflicts label Apr 17, 2023
@rumyantseva rumyantseva removed the no ci label Apr 17, 2023
@rumyantseva rumyantseva marked this pull request as ready for review April 18, 2023 12:32
@rumyantseva rumyantseva requested a review from a team as a code owner April 18, 2023 12:32
@rumyantseva rumyantseva requested review from AlekSi, w84thesun, a team, chilagrow and noisersup April 18, 2023 12:32
noisersup
noisersup approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two separate functions with 2 queries look much more clear! LGTM

w84thesun
w84thesun approved these changes Apr 18, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rumyantseva rumyantseva enabled auto-merge (squash) April 18, 2023 13:14
@rumyantseva rumyantseva merged commit e3c6cf8 into FerretDB:main Apr 18, 2023
@rumyantseva rumyantseva deleted the issue-1346-stats-pg branch April 18, 2023 13:17
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
@fenogentov
Fix SchemaStats to return correct data (FerretDB#2426)
852c4c4 
Closes FerretDB#1346.
Closes FerretDB#1068.
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
@fenogentov
Fix SchemaStats to return correct data (FerretDB#2426)
4e844b1 
Closes FerretDB#1346.
Closes FerretDB#1068.
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
@fenogentov
Fix SchemaStats to return correct data (FerretDB#2426)
6c09a0a 
Closes FerretDB#1346.
Closes FerretDB#1068.
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
@fenogentov
Fix SchemaStats to return correct data (FerretDB#2426)
d9b7ddd 
Closes FerretDB#1346.
Closes FerretDB#1068.
@AlekSi AlekSi added this to the v1.1.0 milestone May 8, 2023
@AlekSi AlekSi added code/bug Some user-visible feature works incorrectly and removed code/enhancement Some user-visible feature could work better labels May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@w84thesun w84thesun w84thesun approved these changes

@AlekSi AlekSi Awaiting requested review from AlekSi AlekSi is a code owner automatically assigned from FerretDB/leads

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow was automatically assigned from FerretDB/core

Assignees

@rumyantseva rumyantseva

Labels
code/bug Some user-visible feature works incorrectly
Projects
Current Engineering
Archived in project
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Fix SchemaStats to return (somewhat) correct data pg: Exclude service tables when calculate statistics
4 participants
@rumyantseva @AlekSi @w84thesun @noisersup