Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use parallel tests consistently #2409

Merged
merged 10 commits into from
Apr 12, 2023
Merged

Use parallel tests consistently #2409

merged 10 commits into from
Apr 12, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Apr 12, 2023 •
edited
Loading

Description

Closes #2394.

  • tests are run parallel on top level test when they can.
  • sub tests are run parallel consistently.
  • fix incorrect compat test runner.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/chore Code maintenance improvements label Apr 12, 2023
@chilagrow chilagrow self-assigned this Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023 •
edited
Loading

Codecov Report

Merging #2409 (42dec64) into main (5d8faeb) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2409   +/-   ##
=======================================
  Coverage   26.87%   26.87%           
=======================================
  Files         392      392           
  Lines       19234    19234           
=======================================
  Hits         5170     5170           
  Misses      13509    13509           
  Partials      555      555
Flag Coverage Δ
integration 4.73% <ø> (ø)
mongodb 4.73% <ø> (ø)
unit 25.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow changed the title Tests are run parallel Make integration tests consistent Apr 12, 2023
@chilagrow chilagrow changed the title Make integration tests consistent Parallel tests are consistently used in integration tests Apr 12, 2023
@chilagrow chilagrow marked this pull request as ready for review April 12, 2023 09:46
@chilagrow chilagrow requested a review from a team as a code owner April 12, 2023 09:46
@AlekSi AlekSi added this to the v1.1.0 milestone Apr 12, 2023
@AlekSi AlekSi enabled auto-merge (squash) April 12, 2023 10:08
rumyantseva
rumyantseva previously approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! As discussed in the call, this should do the trick!

@w84thesun w84thesun requested review from AlekSi and rumyantseva April 12, 2023 13:56
@AlekSi AlekSi requested review from w84thesun and a team April 12, 2023 13:57
@AlekSi AlekSi requested a review from noisersup April 12, 2023 13:57
@AlekSi AlekSi merged commit bd57de7 into FerretDB:main Apr 12, 2023
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 17, 2023
@chilagrow @fenogentov
Parallel tests are consistently used in integration tests (FerretDB#2409
e5cbda3 
)

Closes FerretDB#2394.
@AlekSi AlekSi changed the title Parallel tests are consistently used in integration tests Use parallel tests consistently May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w84thesun w84thesun w84thesun approved these changes

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@chilagrow chilagrow

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Fix handling of internal errors
4 participants
@chilagrow @AlekSi @w84thesun @rumyantseva