Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve fuzzing with recorded seed data #2392

Merged
merged 174 commits into from
May 4, 2023
Merged

Improve fuzzing with recorded seed data #2392

merged 174 commits into from
May 4, 2023

Conversation

fenogentov
Copy link
Contributor

@fenogentov fenogentov commented Apr 10, 2023 •
edited
Loading

Description

Closes #2100.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@codecov
Copy link

codecov bot commented Apr 10, 2023 •
edited
Loading

Codecov Report

Merging #2392 (7db9382) into main (5a7465c) will decrease coverage by 0.80%.
The diff coverage is 78.57%.

❗ Current head 7db9382 differs from pull request most recent head 20eb8ac. Consider uploading reports for the commit 20eb8ac to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2392      +/-   ##
==========================================
- Coverage   65.15%   64.35%   -0.80%     
==========================================
  Files         410      405       -5     
  Lines       20058    20128      +70     
==========================================
- Hits        13069    12954     -115     
- Misses       6051     6236     +185     
  Partials      938      938
Impacted Files Coverage Δ
internal/clientconn/conn.go 46.23% <78.57%> (+0.52%) ⬆️

... and 16 files with indirect coverage changes

Flag Coverage Δ
integration 57.10% <78.57%> (-0.79%) ⬇️
mongodb 5.02% <0.00%> (-0.02%) ⬇️
pg 57.03% <78.57%> (-0.79%) ⬇️
unit 25.57% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added this to the v1.1.0 milestone Apr 10, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Apr 10, 2023
@AlekSi AlekSi changed the title WIP Improve fuzzing with recorded seed data Apr 10, 2023
@mergify
Copy link
Contributor

mergify bot commented Apr 14, 2023

@fenogentov this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Apr 14, 2023
AlekSi and others added 18 commits April 17, 2023 21:17
@AlekSi @fenogentov
Fix types order linter (FerretDB#2391)
e23198f 
Closes FerretDB#1630.
@AlekSi @Fashander
@ptrfarkas @fenogentov
Add blogpost: Announcing FerretDB 1.0 GA - a truly Open Source MongoD…
478912e 
…B alternative (FerretDB#2397)

Co-authored-by: Alexander Tobi Fashakin <alexander.fashakin@ferretdb.io>
Co-authored-by: Peter Farkas <53900920+ptrfarkas@users.noreply.github.com>
@chilagrow @fenogentov
Deprecated error cleanup (FerretDB#2411)
070e3bc
@AlekSi @fenogentov
Bump deps (FerretDB#2408)
646f5e5
@chilagrow @fenogentov
Fix findAndModify for $exists query operator (FerretDB#2385)
63001bb
@AlekSi @fenogentov
Update documentation for index options (FerretDB#2417)
54c7a03
@chilagrow @fenogentov
Parallel tests are consistently used in integration tests (FerretDB#2409
e5cbda3 
)

Closes FerretDB#2394.
@ptrfarkas @fenogentov
Update 2023-04-11-ferretdb-1-0-ga-opensource-mongodb-alternative.md
f0d90cb
@ptrfarkas @fenogentov
Update 2023-04-11-ferretdb-1-0-ga-opensource-mongodb-alternative.md
298d6c8
@noisersup @fenogentov
Add query pushdown documentation (FerretDB#2339)
eb0cd70 
Closes FerretDB#1956.
@cooljeanius @fenogentov
Update README.md to link to SSPL (FerretDB#2420)
d65804b
@noisersup @fenogentov
Compress CI artifacts (FerretDB#2424)
e5c49b4 
Closes FerretDB#2086.
@ptrfarkas @fenogentov
Update README.md
1d43c77 
Added Managed FerretDB at Cloud providers
@j0holo @fenogentov
Use exponential backoff with jitter (FerretDB#2419)
be00196 
Closes FerretDB#1720.
@AlekSi @fenogentov
Improve documentation for Docker (FerretDB#2396)
2fd13be 
Closes FerretDB/engineering#27.
@AlekSi @fenogentov
Add Mergify rules for blog posts (FerretDB#2434)
8da0258
@AuruTus @fenogentov
Add more detailed PR guides in CONTRIBUTING.md (FerretDB#2435)
14a3a8c 
Closes FerretDB#2427.
@fenogentov
Migrate to pgx/v5 (FerretDB#2439)
0656ccf 
Closes FerretDB#1717.
@AlekSi AlekSi requested a review from w84thesun April 21, 2023 19:10
w84thesun
w84thesun reviewed Apr 24, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a couple of comments. Please feel free to ping me on Slack if you need further help with this PR.

internal/clientconn/conn.go Outdated Show resolved Hide resolved
Taskfile.yml Outdated Show resolved Hide resolved
@fenogentov fenogentov marked this pull request as ready for review May 4, 2023 06:15
@fenogentov fenogentov requested a review from a team as a code owner May 4, 2023 06:16
@fenogentov fenogentov requested a review from chilagrow May 4, 2023 06:16
fenogentov
fenogentov commented May 4, 2023
View reviewed changes
Copy link
Contributor Author

@fenogentov fenogentov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

fenogentov
fenogentov commented May 4, 2023
View reviewed changes
Copy link
Contributor Author

@fenogentov fenogentov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix

@AlekSi AlekSi enabled auto-merge (squash) May 4, 2023 07:53
@AlekSi AlekSi requested review from w84thesun and AlekSi and removed request for chilagrow May 4, 2023 07:53
AlekSi
AlekSi reviewed May 4, 2023
View reviewed changes
internal/clientconn/conn.go Outdated Show resolved Hide resolved
internal/clientconn/conn.go Outdated Show resolved Hide resolved
auto-merge was automatically disabled May 4, 2023 16:43

Head branch was pushed to by a user without write access

@fenogentov fenogentov requested a review from AlekSi May 4, 2023 16:46
@AlekSi AlekSi merged commit 9884aec into FerretDB:main May 4, 2023
@AlekSi
Copy link
Member

AlekSi commented May 4, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekSi AlekSi AlekSi approved these changes

@w84thesun w84thesun Awaiting requested review from w84thesun

Assignees

@fenogentov fenogentov

Labels
code/chore Code maintenance improvements
Projects
Current Engineering
Archived in project
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Improve fuzzing with recorded seed data