Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version.txt generation for git tags #2388

Merged
merged 5 commits into from
Apr 7, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Apr 7, 2023

Description

Closes #2368.
Refs actions/checkout#290.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Apr 7, 2023
@AlekSi AlekSi added this to the v1.0.0 GA milestone Apr 7, 2023
@AlekSi AlekSi self-assigned this Apr 7, 2023
@AlekSi AlekSi added the no ci label Apr 7, 2023
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #2388 (9029007) into main (e1693dd) will decrease coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2388      +/-   ##
==========================================
- Coverage   64.04%   63.99%   -0.05%     
==========================================
  Files         391      391              
  Lines       18987    18987              
==========================================
- Hits        12160    12151       -9     
- Misses       5923     5929       +6     
- Partials      904      907       +3     

see 1 file with indirect coverage changes

Flag Coverage Δ
integration 56.89% <ø> (-0.05%) ⬇️
mongodb 4.79% <ø> (ø)
pg 56.81% <ø> (-0.05%) ⬇️
unit 25.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi changed the title Debug tags Fix version.txt generation for git tags Apr 7, 2023
@AlekSi AlekSi marked this pull request as ready for review April 7, 2023 14:13
@AlekSi AlekSi enabled auto-merge (squash) April 7, 2023 14:14
@AlekSi AlekSi requested review from a team, w84thesun, rumyantseva, chilagrow and noisersup April 7, 2023 14:14
@AlekSi AlekSi removed the no ci label Apr 7, 2023
@AlekSi AlekSi merged commit e2e95e5 into FerretDB:main Apr 7, 2023
@AlekSi AlekSi deleted the fix-version-extraction branch April 7, 2023 15:22
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 11, 2023
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version generation does not work correctly for git tags on CI
3 participants