Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement $project pipeline aggregation stage #2383

Merged
merged 11 commits into from
Apr 21, 2023
Merged

Implement $project pipeline aggregation stage #2383

merged 11 commits into from
Apr 21, 2023

Conversation

w84thesun
Copy link
Contributor

@w84thesun w84thesun commented Apr 6, 2023 •
edited
Loading

Description

Closes #2382.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@w84thesun w84thesun added code/feature Some user-visible feature is not implemented yet no ci labels Apr 6, 2023
@w84thesun w84thesun self-assigned this Apr 6, 2023
@w84thesun w84thesun marked this pull request as ready for review April 20, 2023 12:29
@w84thesun w84thesun requested a review from a team as a code owner April 20, 2023 12:29
@w84thesun w84thesun requested review from AlekSi and chilagrow April 20, 2023 12:29
@w84thesun w84thesun removed the no ci label Apr 20, 2023
@w84thesun w84thesun enabled auto-merge (squash) April 20, 2023 12:30
@w84thesun w84thesun requested review from a team, rumyantseva and noisersup April 20, 2023 12:30
@codecov
Copy link

codecov bot commented Apr 20, 2023 •
edited
Loading

Codecov Report

Merging #2383 (d8e32b4) into main (b1cc4e8) will decrease coverage by 38.25%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2383       +/-   ##
===========================================
- Coverage   64.65%   26.41%   -38.25%     
===========================================
  Files         397      398        +1     
  Lines       19643    19681       +38     
===========================================
- Hits        12701     5199     -7502     
- Misses       6029    13925     +7896     
+ Partials      913      557      -356
Impacted Files Coverage Δ
...nal/handlers/common/aggregations/stages/project.go 0.00% <0.00%> (ø)
...rnal/handlers/common/aggregations/stages/stages.go 0.00% <ø> (-20.00%) ⬇️
internal/handlers/common/projection.go 0.00% <0.00%> (-73.86%) ⬇️
internal/handlers/common/projection_iterator.go 0.00% <0.00%> (-90.00%) ⬇️
internal/handlers/commonerrors/error.go 0.00% <ø> (-48.39%) ⬇️
internal/handlers/commonerrors/errorcode_string.go 80.00% <ø> (ø)

... and 123 files with indirect coverage changes

Flag Coverage Δ
integration 5.04% <0.00%> (-52.79%) ⬇️
mongodb 5.04% <0.00%> (-0.01%) ⬇️
pg ?
unit 25.04% <0.00%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

chilagrow
chilagrow reviewed Apr 21, 2023
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just tiny comments

internal/handlers/common/aggregations/stages/project.go Outdated Show resolved Hide resolved
internal/handlers/common/aggregations/stages/project.go Show resolved Hide resolved
noisersup
noisersup previously approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from comment above looks good to me!

rumyantseva
rumyantseva approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@w84thesun w84thesun merged commit 2cddf07 into FerretDB:main Apr 21, 2023
@w84thesun w84thesun deleted the issue-2382-add-project-aggregation-pipeline branch April 21, 2023 16:51
@AlekSi AlekSi added this to the v1.1.0 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi Awaiting requested review from AlekSi AlekSi is a code owner automatically assigned from FerretDB/leads

@chilagrow chilagrow Awaiting requested review from chilagrow

Assignees

@w84thesun w84thesun

Labels
code/feature Some user-visible feature is not implemented yet
Projects
Current Engineering
Archived in project
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

Implement $project pipeline stage
5 participants
@w84thesun @rumyantseva @chilagrow @noisersup @AlekSi