Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update writing guide #2373

Merged
merged 4 commits into from
Apr 6, 2023
Merged

Conversation

Fashander
Copy link
Member

Description

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@Fashander Fashander added the documentation Something user-visible is badly or not documented label Apr 5, 2023
@Fashander Fashander added this to the v1.0.0 GA milestone Apr 5, 2023
@Fashander Fashander self-assigned this Apr 5, 2023
@mergify
Copy link
Contributor

mergify bot commented Apr 5, 2023

@Fashander this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Apr 5, 2023
@Fashander Fashander force-pushed the update-writing-guide branch from 4570d36 to e6a16a3 Compare April 5, 2023 11:03
@mergify mergify bot removed the conflict PRs that have merge conflicts label Apr 5, 2023
@Fashander Fashander marked this pull request as ready for review April 5, 2023 11:06
@Fashander Fashander requested review from a team, AlekSi and ptrfarkas April 5, 2023 11:06
@Fashander Fashander enabled auto-merge (squash) April 5, 2023 11:07
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #2373 (79802a1) into main (90aace9) will decrease coverage by 36.79%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2373       +/-   ##
===========================================
- Coverage   64.01%   27.22%   -36.79%     
===========================================
  Files         391      391               
  Lines       18987    18987               
===========================================
- Hits        12154     5170     -6984     
- Misses       5927    13262     +7335     
+ Partials      906      555      -351     

see 125 files with indirect coverage changes

Flag Coverage Δ
integration 4.79% <ø> (-52.12%) ⬇️
mongodb 4.79% <ø> (ø)
pg ?
unit 25.88% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

website/docs/contributing/writing-guide.md Outdated Show resolved Hide resolved
website/docs/contributing/writing-guide.md Outdated Show resolved Hide resolved
@Fashander Fashander requested a review from AlekSi April 5, 2023 13:26
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Fashander Fashander merged commit e1693dd into FerretDB:main Apr 6, 2023
fenogentov pushed a commit to fenogentov/FerretDB that referenced this pull request Apr 11, 2023
@Fashander Fashander deleted the update-writing-guide branch December 4, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Something user-visible is badly or not documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants