Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to get logs #2355

Merged
merged 10 commits into from
Apr 5, 2023
Merged

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Apr 4, 2023

Description

Closes #2354.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the documentation Something user-visible is badly or not documented label Apr 4, 2023
@chilagrow chilagrow self-assigned this Apr 4, 2023
@chilagrow chilagrow force-pushed the issue-2354-document-logs branch from 293bf93 to 2867c61 Compare April 4, 2023 07:50
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #2355 (5a378dc) into main (309e970) will decrease coverage by 36.94%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2355       +/-   ##
===========================================
- Coverage   63.99%   27.06%   -36.94%     
===========================================
  Files         391      391               
  Lines       18987    18987               
===========================================
- Hits        12151     5139     -7012     
- Misses       5929    13294     +7365     
+ Partials      907      554      -353     

see 125 files with indirect coverage changes

Flag Coverage Δ
integration 4.79% <ø> (-52.11%) ⬇️
mongodb 4.79% <ø> (ø)
pg ?
unit 25.71% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

website/docs/logs.md Outdated Show resolved Hide resolved
@chilagrow chilagrow changed the title Document logs Document how to get logs Apr 4, 2023
@chilagrow chilagrow requested review from a team, w84thesun, rumyantseva and noisersup April 4, 2023 08:10
@chilagrow chilagrow marked this pull request as ready for review April 4, 2023 08:10
@chilagrow chilagrow requested review from a team, AlekSi, Fashander and ptrfarkas April 4, 2023 08:10
@chilagrow chilagrow added the do not merge PRs that should not be merged label Apr 4, 2023
@chilagrow chilagrow enabled auto-merge (squash) April 4, 2023 08:11
@chilagrow
Copy link
Member Author

Added do-not-merge tag while I check if I've missed something.

rumyantseva
rumyantseva previously approved these changes Apr 4, 2023
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The explanation looks clear and correct to me, I'm not sure if @AlekSi wanted to include more info though.

w84thesun
w84thesun previously approved these changes Apr 4, 2023
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AlekSi AlekSi added the trust PRs that can access Actions secrets label Apr 4, 2023
@AlekSi AlekSi added this to the v1.0.0 GA milestone Apr 4, 2023
@AlekSi
Copy link
Member

AlekSi commented Apr 4, 2023

@Fashander PTAL

website/docs/logs.md Outdated Show resolved Hide resolved
website/docs/logs.md Outdated Show resolved Hide resolved
Fashander
Fashander previously approved these changes Apr 4, 2023
Copy link
Member

@Fashander Fashander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left a few some suggestions

@chilagrow chilagrow dismissed stale reviews from Fashander, rumyantseva, and w84thesun via f3465a2 April 5, 2023 01:07
@chilagrow chilagrow temporarily deployed to cloudflare-dev April 5, 2023 01:07 — with GitHub Actions Inactive
Co-authored-by: Alexander Tobi Fashakin <tobyton2008@yahoo.co.uk>
@chilagrow chilagrow temporarily deployed to cloudflare-dev April 5, 2023 01:11 — with GitHub Actions Inactive
@AlekSi
Copy link
Member

AlekSi commented Apr 5, 2023

CleanShot 2023-04-05 at 08 12 45@2x

@Fashander Is the new sidebar structure good enough for you?

@AlekSi AlekSi requested a review from Fashander April 5, 2023 04:14
Fashander
Fashander previously approved these changes Apr 5, 2023
Copy link
Member

@Fashander Fashander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chilagrow chilagrow temporarily deployed to cloudflare-dev April 5, 2023 09:00 — with GitHub Actions Inactive
@chilagrow chilagrow requested a review from Fashander April 5, 2023 09:02
@chilagrow chilagrow removed the do not merge PRs that should not be merged label Apr 5, 2023
@chilagrow chilagrow temporarily deployed to cloudflare-dev April 5, 2023 09:13 — with GitHub Actions Inactive
@w84thesun w84thesun temporarily deployed to cloudflare-dev April 5, 2023 10:11 — with GitHub Actions Inactive
@chilagrow chilagrow added no ci and removed no ci labels Apr 5, 2023
@chilagrow chilagrow temporarily deployed to cloudflare-dev April 5, 2023 12:48 — with GitHub Actions Inactive
@AlekSi AlekSi temporarily deployed to cloudflare-dev April 5, 2023 18:10 — with GitHub Actions Inactive
@chilagrow chilagrow merged commit 90aace9 into FerretDB:main Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Something user-visible is badly or not documented trust PRs that can access Actions secrets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to get logs
5 participants