Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document test script #2353

Merged
merged 10 commits into from
Apr 4, 2023
Merged

Document test script #2353

merged 10 commits into from
Apr 4, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Apr 4, 2023 •
edited
Loading

Description

Closes #2240.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@codecov
Copy link

codecov bot commented Apr 4, 2023 •
edited
Loading

Codecov Report

Merging #2353 (31694c5) into main (6734769) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2353      +/-   ##
==========================================
+ Coverage   64.01%   64.03%   +0.02%     
==========================================
  Files         391      391              
  Lines       18993    18993              
==========================================
+ Hits        12158    12162       +4     
+ Misses       5929     5925       -4     
  Partials      906      906

see 4 files with indirect coverage changes

Flag Coverage Δ
integration 56.91% <ø> (+0.02%) ⬆️
mongodb 4.79% <ø> (ø)
pg 56.83% <ø> (+0.02%) ⬆️
unit 25.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow self-assigned this Apr 4, 2023
@chilagrow chilagrow added the documentation Something user-visible is badly or not documented label Apr 4, 2023
@chilagrow chilagrow requested review from a team, w84thesun, rumyantseva and noisersup April 4, 2023 03:19
@chilagrow chilagrow marked this pull request as ready for review April 4, 2023 03:19
@chilagrow chilagrow requested a review from AlekSi as a code owner April 4, 2023 03:19
@chilagrow chilagrow enabled auto-merge (squash) April 4, 2023 03:19
rumyantseva
rumyantseva previously approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The text looks clear to me!

.github/ISSUE_TEMPLATE/bug.yml Outdated Show resolved Hide resolved
@chilagrow chilagrow requested a review from rumyantseva April 4, 2023 08:01
rumyantseva
rumyantseva previously approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

w84thesun
w84thesun previously approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chilagrow chilagrow dismissed stale reviews from w84thesun and rumyantseva via 31694c5 April 4, 2023 08:24
AlekSi
AlekSi approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@chilagrow chilagrow merged commit 2a5f745 into FerretDB:main Apr 4, 2023
@AlekSi AlekSi added this to the v1.0.0 GA milestone Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fashander Fashander Fashander approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi AlekSi approved these changes

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

@w84thesun w84thesun Awaiting requested review from w84thesun

Assignees

@chilagrow chilagrow

Labels
documentation Something user-visible is badly or not documented
Projects
None yet
Milestone
v1.0.0 GA
Development

Successfully merging this pull request may close these issues.

Document test script
5 participants
@chilagrow @AlekSi @w84thesun @rumyantseva @Fashander