Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support count and storageStats fields in $collStats aggregation pipeline stage #2338

Merged
merged 44 commits into from
Apr 3, 2023

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented Mar 31, 2023

Description

Closes #1416.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #2338 (c264984) into main (720da63) will decrease coverage by 0.15%.
The diff coverage is 52.46%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2338      +/-   ##
==========================================
- Coverage   64.13%   63.98%   -0.15%     
==========================================
  Files         389      391       +2     
  Lines       18657    18993     +336     
==========================================
+ Hits        11965    12152     +187     
- Misses       5788     5933     +145     
- Partials      904      908       +4     
Impacted Files Coverage Δ
internal/handlers/common/aggregations/stage.go 20.00% <ø> (ø)
internal/handlers/commonerrors/error.go 48.38% <ø> (ø)
internal/handlers/commonerrors/errorcode_string.go 80.00% <ø> (ø)
internal/handlers/tigris/msg_aggregate.go 0.00% <0.00%> (ø)
internal/handlers/tigris/msg_collstats.go 0.00% <0.00%> (ø)
internal/handlers/pg/msg_datasize.go 69.64% <60.00%> (+9.26%) ⬆️
...nternal/handlers/common/aggregations/statistics.go 68.42% <68.42%> (ø)
internal/handlers/pg/msg_aggregate.go 79.90% <79.41%> (+2.00%) ⬆️
internal/handlers/common/aggregations/unwind.go 84.78% <83.33%> (+0.33%) ⬆️
internal/handlers/pg/msg_collstats.go 71.42% <90.90%> (+5.51%) ⬆️
... and 8 more

... and 1 file with indirect coverage changes

Flag Coverage Δ
integration 56.86% <52.46%> (-0.03%) ⬇️
mongodb 4.79% <0.00%> (-0.09%) ⬇️
pg 56.78% <52.46%> (-0.03%) ⬇️
unit 25.92% <0.00%> (-0.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rumyantseva rumyantseva changed the title Altenative stats aggegation Implement simple solution for count and storageStats in $collStats aggregation pipeline stage Apr 2, 2023
@rumyantseva rumyantseva added the code/feature Some user-visible feature is not implemented yet label Apr 2, 2023
@rumyantseva rumyantseva changed the title Implement simple solution for count and storageStats in $collStats aggregation pipeline stage Support count and storageStats fields in $collStats aggregation pipeline stage Apr 2, 2023
@mergify mergify bot removed the conflict PRs that have merge conflicts label Apr 3, 2023
@rumyantseva rumyantseva requested a review from chilagrow April 3, 2023 12:05
w84thesun
w84thesun previously approved these changes Apr 3, 2023
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 👍

@mergify
Copy link
Contributor

mergify bot commented Apr 3, 2023

@rumyantseva this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Apr 3, 2023
@mergify mergify bot removed the conflict PRs that have merge conflicts label Apr 3, 2023
@rumyantseva rumyantseva requested a review from w84thesun April 3, 2023 14:05
@AlekSi AlekSi requested review from a team April 3, 2023 14:07
@AlekSi AlekSi added this to the v1.0.0 GA milestone Apr 3, 2023
@AlekSi AlekSi disabled auto-merge April 3, 2023 14:27
@AlekSi AlekSi merged commit 3059e50 into FerretDB:main Apr 3, 2023
efirs added a commit to tigrisdata-archive/ferretdb that referenced this pull request Apr 11, 2023
v1.0.0
https://github.com/FerretDB/FerretDB/releases/tag/v1.0.0
2023-04-03

We are delighted to announce the release of FerretDB 1.0 GA!

* Support `$sum` accumulator of `$group` aggregation by @chilagrow in FerretDB#2292
* Implement `createIndexes` command by @rumyantseva in FerretDB#2244
* Add basic `getMore` command by @AlekSi in FerretDB#2309
* Implement `dropIndexes` command by @chilagrow in FerretDB#2313
* Implement `$limit` aggregation pipeline stage by @noisersup in FerretDB#2270
* Add partial support for `collStats`, `dbStats` and `dataSize` by @AlekSi in FerretDB#2322
* Implement `$skip` aggregation pipeline stage by @w84thesun in FerretDB#2310
* Implement `$unwind` aggregation pipeline stage by @noisersup in FerretDB#2294
* Support `count` and `storageStats` fields in `$collStats` aggregation pipeline stage by @rumyantseva in FerretDB#2338

* Fix dot notation negative index errors by @w84thesun in FerretDB#2246
* Apply `skip` before `limit` by @AlekSi in FerretDB#2351

* Update supported command for `$sum` aggregation operator by @chilagrow in FerretDB#2318
* Add supported shells and GUIs images by @AlekSi in FerretDB#2323
* Publish FerretDB v0.9.4 blog post by @Fashander in FerretDB#2268
* Use dashes instead of underscores or spaces by @AlekSi in FerretDB#2329
* Update documentation sidebar by @Fashander in FerretDB#2347
* Update FerretDB descriptions by @AlekSi in FerretDB#2281
* Improve flags documentation by @AlekSi in FerretDB#2331
* Describe supported fields for `$collStats` aggregation stage by @rumyantseva in FerretDB#2352

* Use iterators for `sort`, `limit`, `skip`, and `projection` by @AlekSi in FerretDB#2254
* Bump dependencies by @AlekSi in FerretDB#2307
* Improve resource tracking by @AlekSi in FerretDB#2319
* Add tests for `find`'s and `count`'s `skip` argument by @w84thesun in FerretDB#2325
* Close iterator properly by @AlekSi in FerretDB#2333
* Improve large numbers initialization in test data by @noisersup in FerretDB#2324
* Ignore `unique` index option for now by @AlekSi in FerretDB#2350

All closed issues and pull requests: https://github.com/FerretDB/FerretDB/milestone/39?closed=1
All commits: FerretDB/FerretDB@v0.9.4...v1.0.0
efirs added a commit to tigrisdata-archive/ferretdb that referenced this pull request Apr 11, 2023
v1.0.0
https://github.com/FerretDB/FerretDB/releases/tag/v1.0.0
2023-04-03

We are delighted to announce the release of FerretDB 1.0 GA!

* Support `$sum` accumulator of `$group` aggregation by @chilagrow in FerretDB#2292
* Implement `createIndexes` command by @rumyantseva in FerretDB#2244
* Add basic `getMore` command by @AlekSi in FerretDB#2309
* Implement `dropIndexes` command by @chilagrow in FerretDB#2313
* Implement `$limit` aggregation pipeline stage by @noisersup in FerretDB#2270
* Add partial support for `collStats`, `dbStats` and `dataSize` by @AlekSi in FerretDB#2322
* Implement `$skip` aggregation pipeline stage by @w84thesun in FerretDB#2310
* Implement `$unwind` aggregation pipeline stage by @noisersup in FerretDB#2294
* Support `count` and `storageStats` fields in `$collStats` aggregation pipeline stage by @rumyantseva in FerretDB#2338

* Fix dot notation negative index errors by @w84thesun in FerretDB#2246
* Apply `skip` before `limit` by @AlekSi in FerretDB#2351

* Update supported command for `$sum` aggregation operator by @chilagrow in FerretDB#2318
* Add supported shells and GUIs images by @AlekSi in FerretDB#2323
* Publish FerretDB v0.9.4 blog post by @Fashander in FerretDB#2268
* Use dashes instead of underscores or spaces by @AlekSi in FerretDB#2329
* Update documentation sidebar by @Fashander in FerretDB#2347
* Update FerretDB descriptions by @AlekSi in FerretDB#2281
* Improve flags documentation by @AlekSi in FerretDB#2331
* Describe supported fields for `$collStats` aggregation stage by @rumyantseva in FerretDB#2352

* Use iterators for `sort`, `limit`, `skip`, and `projection` by @AlekSi in FerretDB#2254
* Bump dependencies by @AlekSi in FerretDB#2307
* Improve resource tracking by @AlekSi in FerretDB#2319
* Add tests for `find`'s and `count`'s `skip` argument by @w84thesun in FerretDB#2325
* Close iterator properly by @AlekSi in FerretDB#2333
* Improve large numbers initialization in test data by @noisersup in FerretDB#2324
* Ignore `unique` index option for now by @AlekSi in FerretDB#2350

All closed issues and pull requests: https://github.com/FerretDB/FerretDB/milestone/39?closed=1
All commits: FerretDB/FerretDB@v0.9.4...v1.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/feature Some user-visible feature is not implemented yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement $collStats aggregation pipeline stage
4 participants