Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve resource tracking #2319

Merged
merged 5 commits into from
Mar 29, 2023
Merged

Improve resource tracking #2319

merged 5 commits into from
Mar 29, 2023

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Mar 29, 2023

Description

Closes #2309.
Closes #2314.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Mar 29, 2023
@AlekSi AlekSi added this to the v1.0.0 GA milestone Mar 29, 2023
@AlekSi AlekSi self-assigned this Mar 29, 2023
@FerretDB FerretDB deleted a comment from mergify bot Mar 29, 2023
@AlekSi AlekSi added the no ci label Mar 29, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2023

⚠️ The sha of the head commit of this PR conflicts with #2309. Mergify cannot evaluate rules on this PR. ⚠️

@AlekSi AlekSi removed the no ci label Mar 29, 2023
@AlekSi AlekSi marked this pull request as ready for review March 29, 2023 10:27
@AlekSi AlekSi requested a review from a team as a code owner March 29, 2023 10:27
@AlekSi AlekSi enabled auto-merge (squash) March 29, 2023 10:27
@AlekSi AlekSi requested review from a team and noisersup March 29, 2023 10:27
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #2319 (4136b83) into main (d21a012) will decrease coverage by 34.82%.
The diff coverage is 64.17%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2319       +/-   ##
===========================================
- Coverage   63.35%   28.53%   -34.82%     
===========================================
  Files         379      381        +2     
  Lines       17707    17758       +51     
===========================================
- Hits        11218     5068     -6150     
- Misses       5610    12154     +6544     
+ Partials      879      536      -343     
Impacted Files Coverage Δ
internal/clientconn/conn.go 0.00% <0.00%> (-45.25%) ⬇️
internal/clientconn/conninfo/conn_info.go 16.21% <0.00%> (-29.24%) ⬇️
internal/clientconn/conninfo/cursor.go 0.00% <0.00%> (ø)
internal/handlers/common/aggregations/group.go 0.00% <0.00%> (-87.43%) ⬇️
internal/handlers/pg/pgdb/collections.go 60.71% <0.00%> (-7.15%) ⬇️
internal/handlers/pg/pgdb/transactions.go 69.73% <ø> (-2.64%) ⬇️
internal/util/telemetry/reporter.go 5.91% <ø> (ø)
internal/util/resource/resource.go 67.85% <67.85%> (ø)
internal/util/iterator/values.go 94.73% <93.75%> (-5.27%) ⬇️
internal/clientconn/listener.go 54.40% <100.00%> (-18.66%) ⬇️
... and 5 more

... and 111 files with indirect coverage changes

Flag Coverage Δ
integration 5.04% <0.00%> (-50.70%) ⬇️
mongodb 5.04% <0.00%> (-0.02%) ⬇️
pg ?
unit 27.22% <64.17%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi AlekSi added the no ci label Mar 29, 2023
@AlekSi AlekSi removed the no ci label Mar 29, 2023
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check super attentively as there are a lot of changes, but I didn't see red flags at first sight.

@AlekSi AlekSi disabled auto-merge March 29, 2023 15:25
@AlekSi AlekSi enabled auto-merge (squash) March 29, 2023 15:26
@AlekSi AlekSi disabled auto-merge March 29, 2023 15:26
@AlekSi AlekSi merged commit b5f96c2 into FerretDB:main Mar 29, 2023
@AlekSi AlekSi deleted the resources branch March 29, 2023 15:26
efirs added a commit to tigrisdata-archive/ferretdb that referenced this pull request Apr 11, 2023
v1.0.0
https://github.com/FerretDB/FerretDB/releases/tag/v1.0.0
2023-04-03

We are delighted to announce the release of FerretDB 1.0 GA!

* Support `$sum` accumulator of `$group` aggregation by @chilagrow in FerretDB#2292
* Implement `createIndexes` command by @rumyantseva in FerretDB#2244
* Add basic `getMore` command by @AlekSi in FerretDB#2309
* Implement `dropIndexes` command by @chilagrow in FerretDB#2313
* Implement `$limit` aggregation pipeline stage by @noisersup in FerretDB#2270
* Add partial support for `collStats`, `dbStats` and `dataSize` by @AlekSi in FerretDB#2322
* Implement `$skip` aggregation pipeline stage by @w84thesun in FerretDB#2310
* Implement `$unwind` aggregation pipeline stage by @noisersup in FerretDB#2294
* Support `count` and `storageStats` fields in `$collStats` aggregation pipeline stage by @rumyantseva in FerretDB#2338

* Fix dot notation negative index errors by @w84thesun in FerretDB#2246
* Apply `skip` before `limit` by @AlekSi in FerretDB#2351

* Update supported command for `$sum` aggregation operator by @chilagrow in FerretDB#2318
* Add supported shells and GUIs images by @AlekSi in FerretDB#2323
* Publish FerretDB v0.9.4 blog post by @Fashander in FerretDB#2268
* Use dashes instead of underscores or spaces by @AlekSi in FerretDB#2329
* Update documentation sidebar by @Fashander in FerretDB#2347
* Update FerretDB descriptions by @AlekSi in FerretDB#2281
* Improve flags documentation by @AlekSi in FerretDB#2331
* Describe supported fields for `$collStats` aggregation stage by @rumyantseva in FerretDB#2352

* Use iterators for `sort`, `limit`, `skip`, and `projection` by @AlekSi in FerretDB#2254
* Bump dependencies by @AlekSi in FerretDB#2307
* Improve resource tracking by @AlekSi in FerretDB#2319
* Add tests for `find`'s and `count`'s `skip` argument by @w84thesun in FerretDB#2325
* Close iterator properly by @AlekSi in FerretDB#2333
* Improve large numbers initialization in test data by @noisersup in FerretDB#2324
* Ignore `unique` index option for now by @AlekSi in FerretDB#2350

All closed issues and pull requests: https://github.com/FerretDB/FerretDB/milestone/39?closed=1
All commits: FerretDB/FerretDB@v0.9.4...v1.0.0
efirs added a commit to tigrisdata-archive/ferretdb that referenced this pull request Apr 11, 2023
v1.0.0
https://github.com/FerretDB/FerretDB/releases/tag/v1.0.0
2023-04-03

We are delighted to announce the release of FerretDB 1.0 GA!

* Support `$sum` accumulator of `$group` aggregation by @chilagrow in FerretDB#2292
* Implement `createIndexes` command by @rumyantseva in FerretDB#2244
* Add basic `getMore` command by @AlekSi in FerretDB#2309
* Implement `dropIndexes` command by @chilagrow in FerretDB#2313
* Implement `$limit` aggregation pipeline stage by @noisersup in FerretDB#2270
* Add partial support for `collStats`, `dbStats` and `dataSize` by @AlekSi in FerretDB#2322
* Implement `$skip` aggregation pipeline stage by @w84thesun in FerretDB#2310
* Implement `$unwind` aggregation pipeline stage by @noisersup in FerretDB#2294
* Support `count` and `storageStats` fields in `$collStats` aggregation pipeline stage by @rumyantseva in FerretDB#2338

* Fix dot notation negative index errors by @w84thesun in FerretDB#2246
* Apply `skip` before `limit` by @AlekSi in FerretDB#2351

* Update supported command for `$sum` aggregation operator by @chilagrow in FerretDB#2318
* Add supported shells and GUIs images by @AlekSi in FerretDB#2323
* Publish FerretDB v0.9.4 blog post by @Fashander in FerretDB#2268
* Use dashes instead of underscores or spaces by @AlekSi in FerretDB#2329
* Update documentation sidebar by @Fashander in FerretDB#2347
* Update FerretDB descriptions by @AlekSi in FerretDB#2281
* Improve flags documentation by @AlekSi in FerretDB#2331
* Describe supported fields for `$collStats` aggregation stage by @rumyantseva in FerretDB#2352

* Use iterators for `sort`, `limit`, `skip`, and `projection` by @AlekSi in FerretDB#2254
* Bump dependencies by @AlekSi in FerretDB#2307
* Improve resource tracking by @AlekSi in FerretDB#2319
* Add tests for `find`'s and `count`'s `skip` argument by @w84thesun in FerretDB#2325
* Close iterator properly by @AlekSi in FerretDB#2333
* Improve large numbers initialization in test data by @noisersup in FerretDB#2324
* Ignore `unique` index option for now by @AlekSi in FerretDB#2350

All closed issues and pull requests: https://github.com/FerretDB/FerretDB/milestone/39?closed=1
All commits: FerretDB/FerretDB@v0.9.4...v1.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use pprof's custom profilers and finalizers
2 participants