Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement $skip aggregation pipeline stage #2310

Merged

Conversation

w84thesun
Copy link
Contributor

@w84thesun w84thesun commented Mar 28, 2023

Description

Closes #1438.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

Dmitry added 2 commits March 28, 2023 18:37
@w84thesun w84thesun added code/feature Some user-visible feature is not implemented yet no ci labels Mar 28, 2023
@w84thesun w84thesun self-assigned this Mar 28, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2023

@w84thesun this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Mar 29, 2023
Dmitry added 2 commits March 29, 2023 21:22
# Conflicts:
#	internal/handlers/commonerrors/errorcode_string.go
@mergify mergify bot removed the conflict PRs that have merge conflicts label Mar 31, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 31, 2023

@w84thesun this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Mar 31, 2023
…e-1438-skip-aggregation-pipeline-stage

# Conflicts:
#	internal/handlers/common/params.go
#	internal/handlers/commonerrors/error.go
#	internal/handlers/commonerrors/errorcode_string.go
@mergify mergify bot removed the conflict PRs that have merge conflicts label Mar 31, 2023
@w84thesun w84thesun removed the no ci label Mar 31, 2023
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #2310 (1ffb920) into main (f0d6f83) will decrease coverage by 0.02%.
The diff coverage is 87.80%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2310      +/-   ##
==========================================
- Coverage   64.05%   64.04%   -0.02%     
==========================================
  Files         387      388       +1     
  Lines       18513    18554      +41     
==========================================
+ Hits        11859    11883      +24     
- Misses       5758     5770      +12     
- Partials      896      901       +5     
Impacted Files Coverage Δ
internal/handlers/common/aggregations/stage.go 26.31% <ø> (ø)
internal/handlers/commonerrors/error.go 48.38% <ø> (ø)
internal/handlers/commonerrors/errorcode_string.go 80.00% <ø> (ø)
internal/handlers/common/aggregations/skip.go 78.57% <78.57%> (ø)
internal/handlers/common/params.go 96.96% <92.59%> (-0.36%) ⬇️

... and 1 file with indirect coverage changes

Flag Coverage Δ
integration 56.73% <87.80%> (+<0.01%) ⬆️
mongodb 4.90% <0.00%> (-0.02%) ⬇️
pg 56.65% <87.80%> (+<0.01%) ⬆️
unit 26.59% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@w84thesun w84thesun marked this pull request as ready for review March 31, 2023 16:27
@w84thesun w84thesun requested a review from a team March 31, 2023 16:27
@w84thesun w84thesun requested a review from a team as a code owner March 31, 2023 16:27
@w84thesun w84thesun enabled auto-merge (squash) March 31, 2023 16:28
@w84thesun w84thesun requested review from a team and noisersup March 31, 2023 16:28
noisersup
noisersup previously approved these changes Mar 31, 2023
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored-by: Chi Fujii <chi.fujii@ferretdb.io>
@w84thesun w84thesun requested review from chilagrow and noisersup April 3, 2023 07:53
@w84thesun w84thesun merged commit 3b6fc9f into FerretDB:main Apr 3, 2023
@w84thesun w84thesun deleted the issue-1438-skip-aggregation-pipeline-stage branch April 3, 2023 08:40
@AlekSi AlekSi added this to the v1.0.0 GA milestone Apr 10, 2023
efirs added a commit to tigrisdata-archive/ferretdb that referenced this pull request Apr 11, 2023
v1.0.0
https://github.com/FerretDB/FerretDB/releases/tag/v1.0.0
2023-04-03

We are delighted to announce the release of FerretDB 1.0 GA!

* Support `$sum` accumulator of `$group` aggregation by @chilagrow in FerretDB#2292
* Implement `createIndexes` command by @rumyantseva in FerretDB#2244
* Add basic `getMore` command by @AlekSi in FerretDB#2309
* Implement `dropIndexes` command by @chilagrow in FerretDB#2313
* Implement `$limit` aggregation pipeline stage by @noisersup in FerretDB#2270
* Add partial support for `collStats`, `dbStats` and `dataSize` by @AlekSi in FerretDB#2322
* Implement `$skip` aggregation pipeline stage by @w84thesun in FerretDB#2310
* Implement `$unwind` aggregation pipeline stage by @noisersup in FerretDB#2294
* Support `count` and `storageStats` fields in `$collStats` aggregation pipeline stage by @rumyantseva in FerretDB#2338

* Fix dot notation negative index errors by @w84thesun in FerretDB#2246
* Apply `skip` before `limit` by @AlekSi in FerretDB#2351

* Update supported command for `$sum` aggregation operator by @chilagrow in FerretDB#2318
* Add supported shells and GUIs images by @AlekSi in FerretDB#2323
* Publish FerretDB v0.9.4 blog post by @Fashander in FerretDB#2268
* Use dashes instead of underscores or spaces by @AlekSi in FerretDB#2329
* Update documentation sidebar by @Fashander in FerretDB#2347
* Update FerretDB descriptions by @AlekSi in FerretDB#2281
* Improve flags documentation by @AlekSi in FerretDB#2331
* Describe supported fields for `$collStats` aggregation stage by @rumyantseva in FerretDB#2352

* Use iterators for `sort`, `limit`, `skip`, and `projection` by @AlekSi in FerretDB#2254
* Bump dependencies by @AlekSi in FerretDB#2307
* Improve resource tracking by @AlekSi in FerretDB#2319
* Add tests for `find`'s and `count`'s `skip` argument by @w84thesun in FerretDB#2325
* Close iterator properly by @AlekSi in FerretDB#2333
* Improve large numbers initialization in test data by @noisersup in FerretDB#2324
* Ignore `unique` index option for now by @AlekSi in FerretDB#2350

All closed issues and pull requests: https://github.com/FerretDB/FerretDB/milestone/39?closed=1
All commits: FerretDB/FerretDB@v0.9.4...v1.0.0
efirs added a commit to tigrisdata-archive/ferretdb that referenced this pull request Apr 11, 2023
v1.0.0
https://github.com/FerretDB/FerretDB/releases/tag/v1.0.0
2023-04-03

We are delighted to announce the release of FerretDB 1.0 GA!

* Support `$sum` accumulator of `$group` aggregation by @chilagrow in FerretDB#2292
* Implement `createIndexes` command by @rumyantseva in FerretDB#2244
* Add basic `getMore` command by @AlekSi in FerretDB#2309
* Implement `dropIndexes` command by @chilagrow in FerretDB#2313
* Implement `$limit` aggregation pipeline stage by @noisersup in FerretDB#2270
* Add partial support for `collStats`, `dbStats` and `dataSize` by @AlekSi in FerretDB#2322
* Implement `$skip` aggregation pipeline stage by @w84thesun in FerretDB#2310
* Implement `$unwind` aggregation pipeline stage by @noisersup in FerretDB#2294
* Support `count` and `storageStats` fields in `$collStats` aggregation pipeline stage by @rumyantseva in FerretDB#2338

* Fix dot notation negative index errors by @w84thesun in FerretDB#2246
* Apply `skip` before `limit` by @AlekSi in FerretDB#2351

* Update supported command for `$sum` aggregation operator by @chilagrow in FerretDB#2318
* Add supported shells and GUIs images by @AlekSi in FerretDB#2323
* Publish FerretDB v0.9.4 blog post by @Fashander in FerretDB#2268
* Use dashes instead of underscores or spaces by @AlekSi in FerretDB#2329
* Update documentation sidebar by @Fashander in FerretDB#2347
* Update FerretDB descriptions by @AlekSi in FerretDB#2281
* Improve flags documentation by @AlekSi in FerretDB#2331
* Describe supported fields for `$collStats` aggregation stage by @rumyantseva in FerretDB#2352

* Use iterators for `sort`, `limit`, `skip`, and `projection` by @AlekSi in FerretDB#2254
* Bump dependencies by @AlekSi in FerretDB#2307
* Improve resource tracking by @AlekSi in FerretDB#2319
* Add tests for `find`'s and `count`'s `skip` argument by @w84thesun in FerretDB#2325
* Close iterator properly by @AlekSi in FerretDB#2333
* Improve large numbers initialization in test data by @noisersup in FerretDB#2324
* Ignore `unique` index option for now by @AlekSi in FerretDB#2350

All closed issues and pull requests: https://github.com/FerretDB/FerretDB/milestone/39?closed=1
All commits: FerretDB/FerretDB@v0.9.4...v1.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/feature Some user-visible feature is not implemented yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement $skip aggregation pipeline stage
4 participants