Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support $sum accumulator of $group aggregation #2292

Merged
merged 14 commits into from
Mar 29, 2023
Merged

Support $sum accumulator of $group aggregation #2292

merged 14 commits into from
Mar 29, 2023

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Mar 27, 2023 •
edited
Loading

Description

Closes #2013.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/feature Some user-visible feature is not implemented yet label Mar 27, 2023
@chilagrow chilagrow self-assigned this Mar 27, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 27, 2023

@chilagrow this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Mar 27, 2023
@AlekSi AlekSi added this to the v1.0.0 GA milestone Mar 27, 2023
@chilagrow chilagrow force-pushed the sum-aggregation-operator branch from 02aa87c to 6a0f709 Compare March 28, 2023 01:31
@mergify mergify bot removed the conflict PRs that have merge conflicts label Mar 28, 2023
@chilagrow chilagrow mentioned this pull request Mar 28, 2023
Open
@chilagrow chilagrow force-pushed the sum-aggregation-operator branch from 523a1ad to 54fe096 Compare March 28, 2023 05:04
@chilagrow chilagrow marked this pull request as ready for review March 28, 2023 05:31
@chilagrow chilagrow requested a review from a team as a code owner March 28, 2023 05:31
@chilagrow chilagrow requested review from AlekSi, w84thesun, rumyantseva, a team and noisersup March 28, 2023 05:31
@chilagrow chilagrow enabled auto-merge (squash) March 28, 2023 05:32
noisersup
noisersup previously approved these changes Mar 28, 2023
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify
Copy link
Contributor

mergify bot commented Mar 28, 2023

@chilagrow this pull request has merge conflicts.

@mergify mergify bot added the conflict PRs that have merge conflicts label Mar 28, 2023
w84thesun
w84thesun previously approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

rumyantseva
rumyantseva previously approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks neat and consistent to me.

I see there is a conflict with main, but I don't have questions about the implementation itself.

@chilagrow chilagrow dismissed stale reviews from rumyantseva, w84thesun, and noisersup via 445c001 March 29, 2023 01:44
@mergify mergify bot removed the conflict PRs that have merge conflicts label Mar 29, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023 •
edited
Loading

Codecov Report

Merging #2292 (cb29b5b) into main (7772636) will increase coverage by 0.18%.
The diff coverage is 98.79%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2292      +/-   ##
==========================================
+ Coverage   58.57%   58.76%   +0.18%     
==========================================
  Files         377      379       +2     
  Lines       17625    17707      +82     
==========================================
+ Hits        10324    10405      +81     
- Misses       6439     6440       +1     
  Partials      862      862
Impacted Files Coverage Δ
integration/shareddata/scalars.go 100.00% <ø> (ø)
internal/handlers/common/aggregations/group.go 87.42% <ø> (ø)
internal/handlers/commonerrors/error.go 48.38% <ø> (ø)
internal/handlers/commonerrors/errorcode_string.go 80.00% <ø> (ø)
internal/handlers/common/aggregations/group_sum.go 97.72% <97.72%> (ø)
integration/shareddata/shareddata.go 89.21% <100.00%> (+0.10%) ⬆️
internal/handlers/common/aggregations/number.go 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

Flag Coverage Δ
integration 47.74% <98.79%> (+0.24%) ⬆️
mongodb 5.05% <2.40%> (-0.02%) ⬇️
tigris 47.63% <98.79%> (+0.32%) ⬆️
unit 27.00% <0.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow requested review from a team, Fashander and ptrfarkas March 29, 2023 01:58
@chilagrow chilagrow force-pushed the sum-aggregation-operator branch from c73097b to 445c001 Compare March 29, 2023 02:02
@AlekSi AlekSi requested review from a team and removed request for Fashander and ptrfarkas March 29, 2023 05:36
rumyantseva
rumyantseva approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

w84thesun
w84thesun approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@chilagrow chilagrow merged commit 4c84078 into FerretDB:main Mar 29, 2023
efirs added a commit to tigrisdata-archive/ferretdb that referenced this pull request Apr 11, 2023
@efirs
Merge tag 'v1.0.0'
c403f7a 
v1.0.0
https://github.com/FerretDB/FerretDB/releases/tag/v1.0.0
2023-04-03

We are delighted to announce the release of FerretDB 1.0 GA!

* Support `$sum` accumulator of `$group` aggregation by @chilagrow in FerretDB#2292
* Implement `createIndexes` command by @rumyantseva in FerretDB#2244
* Add basic `getMore` command by @AlekSi in FerretDB#2309
* Implement `dropIndexes` command by @chilagrow in FerretDB#2313
* Implement `$limit` aggregation pipeline stage by @noisersup in FerretDB#2270
* Add partial support for `collStats`, `dbStats` and `dataSize` by @AlekSi in FerretDB#2322
* Implement `$skip` aggregation pipeline stage by @w84thesun in FerretDB#2310
* Implement `$unwind` aggregation pipeline stage by @noisersup in FerretDB#2294
* Support `count` and `storageStats` fields in `$collStats` aggregation pipeline stage by @rumyantseva in FerretDB#2338

* Fix dot notation negative index errors by @w84thesun in FerretDB#2246
* Apply `skip` before `limit` by @AlekSi in FerretDB#2351

* Update supported command for `$sum` aggregation operator by @chilagrow in FerretDB#2318
* Add supported shells and GUIs images by @AlekSi in FerretDB#2323
* Publish FerretDB v0.9.4 blog post by @Fashander in FerretDB#2268
* Use dashes instead of underscores or spaces by @AlekSi in FerretDB#2329
* Update documentation sidebar by @Fashander in FerretDB#2347
* Update FerretDB descriptions by @AlekSi in FerretDB#2281
* Improve flags documentation by @AlekSi in FerretDB#2331
* Describe supported fields for `$collStats` aggregation stage by @rumyantseva in FerretDB#2352

* Use iterators for `sort`, `limit`, `skip`, and `projection` by @AlekSi in FerretDB#2254
* Bump dependencies by @AlekSi in FerretDB#2307
* Improve resource tracking by @AlekSi in FerretDB#2319
* Add tests for `find`'s and `count`'s `skip` argument by @w84thesun in FerretDB#2325
* Close iterator properly by @AlekSi in FerretDB#2333
* Improve large numbers initialization in test data by @noisersup in FerretDB#2324
* Ignore `unique` index option for now by @AlekSi in FerretDB#2350

All closed issues and pull requests: https://github.com/FerretDB/FerretDB/milestone/39?closed=1
All commits: FerretDB/FerretDB@v0.9.4...v1.0.0
efirs added a commit to tigrisdata-archive/ferretdb that referenced this pull request Apr 11, 2023
@efirs
Merge tag 'v1.0.0'
d4eb8ea 
v1.0.0
https://github.com/FerretDB/FerretDB/releases/tag/v1.0.0
2023-04-03

We are delighted to announce the release of FerretDB 1.0 GA!

* Support `$sum` accumulator of `$group` aggregation by @chilagrow in FerretDB#2292
* Implement `createIndexes` command by @rumyantseva in FerretDB#2244
* Add basic `getMore` command by @AlekSi in FerretDB#2309
* Implement `dropIndexes` command by @chilagrow in FerretDB#2313
* Implement `$limit` aggregation pipeline stage by @noisersup in FerretDB#2270
* Add partial support for `collStats`, `dbStats` and `dataSize` by @AlekSi in FerretDB#2322
* Implement `$skip` aggregation pipeline stage by @w84thesun in FerretDB#2310
* Implement `$unwind` aggregation pipeline stage by @noisersup in FerretDB#2294
* Support `count` and `storageStats` fields in `$collStats` aggregation pipeline stage by @rumyantseva in FerretDB#2338

* Fix dot notation negative index errors by @w84thesun in FerretDB#2246
* Apply `skip` before `limit` by @AlekSi in FerretDB#2351

* Update supported command for `$sum` aggregation operator by @chilagrow in FerretDB#2318
* Add supported shells and GUIs images by @AlekSi in FerretDB#2323
* Publish FerretDB v0.9.4 blog post by @Fashander in FerretDB#2268
* Use dashes instead of underscores or spaces by @AlekSi in FerretDB#2329
* Update documentation sidebar by @Fashander in FerretDB#2347
* Update FerretDB descriptions by @AlekSi in FerretDB#2281
* Improve flags documentation by @AlekSi in FerretDB#2331
* Describe supported fields for `$collStats` aggregation stage by @rumyantseva in FerretDB#2352

* Use iterators for `sort`, `limit`, `skip`, and `projection` by @AlekSi in FerretDB#2254
* Bump dependencies by @AlekSi in FerretDB#2307
* Improve resource tracking by @AlekSi in FerretDB#2319
* Add tests for `find`'s and `count`'s `skip` argument by @w84thesun in FerretDB#2325
* Close iterator properly by @AlekSi in FerretDB#2333
* Improve large numbers initialization in test data by @noisersup in FerretDB#2324
* Ignore `unique` index option for now by @AlekSi in FerretDB#2350

All closed issues and pull requests: https://github.com/FerretDB/FerretDB/milestone/39?closed=1
All commits: FerretDB/FerretDB@v0.9.4...v1.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun w84thesun approved these changes

@AlekSi AlekSi Awaiting requested review from AlekSi AlekSi is a code owner automatically assigned from FerretDB/leads

Assignees

@chilagrow chilagrow

Labels
code/feature Some user-visible feature is not implemented yet
Projects
None yet
Milestone
v1.0.0 GA
Development

Successfully merging this pull request may close these issues.

Implement the $sum aggregation operator
5 participants
@chilagrow @AlekSi @w84thesun @rumyantseva @noisersup