Implement createIndexes command
#2244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rumyantseva
added
the
code/feature
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2244 +/- ##
==========================================
- Coverage 71.53% 63.84% -7.70%
==========================================
Files 381 381
Lines 17758 18001 +243
==========================================
- Hits 12704 11492 -1212
- Misses 4022 5626 +1604
+ Partials 1032 883 -149
... and 54 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
…/rumyantseva/FerretDB into issue-1509-simple-implementation
…/rumyantseva/FerretDB into issue-1509-simple-implementation
rumyantseva
changed the title
createIndex commandcreateIndexes command
|
@rumyantseva this pull request has merge conflicts. |
AlekSi
reviewed
Mar 29, 2023
noisersup
previously approved these changes
Mar 29, 2023
There was a problem hiding this comment.
Thanks for applying changes. I've run postgresql with -c 'standard_conforming_strings=off'.
FerretDB seems to run, mongosh connection is initialized, but after any command we get an error, which is a good solution in my opinion! 👍
test> db.values.find()
MongoServerError: [msg_find.go:38 pg.(*Handler).MsgFind] [pg.go:130 pg.(*Handler).DBPool] pgdb.checkConnection: "standard_conforming_strings" is "off", want "on"
LGTM!
|
@noisersup, thanks for reviewing attentively! That's a critical check! |
chilagrow
previously approved these changes
Mar 30, 2023
chilagrow
dismissed stale reviews from AlekSi, noisersup, and themself
via
ce230c2
chilagrow
approved these changes
Mar 30, 2023
AlekSi
approved these changes
Mar 30, 2023
|
@rumyantseva please do a final look on recent commits and remove
do not merge
|
efirs
added a commit
to tigrisdata-archive/ferretdb
that referenced
this pull request
Apr 11, 2023
v1.0.0 https://github.com/FerretDB/FerretDB/releases/tag/v1.0.0 2023-04-03 We are delighted to announce the release of FerretDB 1.0 GA! * Support `$sum` accumulator of `$group` aggregation by @chilagrow in FerretDB#2292 * Implement `createIndexes` command by @rumyantseva in FerretDB#2244 * Add basic `getMore` command by @AlekSi in FerretDB#2309 * Implement `dropIndexes` command by @chilagrow in FerretDB#2313 * Implement `$limit` aggregation pipeline stage by @noisersup in FerretDB#2270 * Add partial support for `collStats`, `dbStats` and `dataSize` by @AlekSi in FerretDB#2322 * Implement `$skip` aggregation pipeline stage by @w84thesun in FerretDB#2310 * Implement `$unwind` aggregation pipeline stage by @noisersup in FerretDB#2294 * Support `count` and `storageStats` fields in `$collStats` aggregation pipeline stage by @rumyantseva in FerretDB#2338 * Fix dot notation negative index errors by @w84thesun in FerretDB#2246 * Apply `skip` before `limit` by @AlekSi in FerretDB#2351 * Update supported command for `$sum` aggregation operator by @chilagrow in FerretDB#2318 * Add supported shells and GUIs images by @AlekSi in FerretDB#2323 * Publish FerretDB v0.9.4 blog post by @Fashander in FerretDB#2268 * Use dashes instead of underscores or spaces by @AlekSi in FerretDB#2329 * Update documentation sidebar by @Fashander in FerretDB#2347 * Update FerretDB descriptions by @AlekSi in FerretDB#2281 * Improve flags documentation by @AlekSi in FerretDB#2331 * Describe supported fields for `$collStats` aggregation stage by @rumyantseva in FerretDB#2352 * Use iterators for `sort`, `limit`, `skip`, and `projection` by @AlekSi in FerretDB#2254 * Bump dependencies by @AlekSi in FerretDB#2307 * Improve resource tracking by @AlekSi in FerretDB#2319 * Add tests for `find`'s and `count`'s `skip` argument by @w84thesun in FerretDB#2325 * Close iterator properly by @AlekSi in FerretDB#2333 * Improve large numbers initialization in test data by @noisersup in FerretDB#2324 * Ignore `unique` index option for now by @AlekSi in FerretDB#2350 All closed issues and pull requests: https://github.com/FerretDB/FerretDB/milestone/39?closed=1 All commits: FerretDB/FerretDB@v0.9.4...v1.0.0
efirs
added a commit
to tigrisdata-archive/ferretdb
that referenced
this pull request
Apr 11, 2023
v1.0.0 https://github.com/FerretDB/FerretDB/releases/tag/v1.0.0 2023-04-03 We are delighted to announce the release of FerretDB 1.0 GA! * Support `$sum` accumulator of `$group` aggregation by @chilagrow in FerretDB#2292 * Implement `createIndexes` command by @rumyantseva in FerretDB#2244 * Add basic `getMore` command by @AlekSi in FerretDB#2309 * Implement `dropIndexes` command by @chilagrow in FerretDB#2313 * Implement `$limit` aggregation pipeline stage by @noisersup in FerretDB#2270 * Add partial support for `collStats`, `dbStats` and `dataSize` by @AlekSi in FerretDB#2322 * Implement `$skip` aggregation pipeline stage by @w84thesun in FerretDB#2310 * Implement `$unwind` aggregation pipeline stage by @noisersup in FerretDB#2294 * Support `count` and `storageStats` fields in `$collStats` aggregation pipeline stage by @rumyantseva in FerretDB#2338 * Fix dot notation negative index errors by @w84thesun in FerretDB#2246 * Apply `skip` before `limit` by @AlekSi in FerretDB#2351 * Update supported command for `$sum` aggregation operator by @chilagrow in FerretDB#2318 * Add supported shells and GUIs images by @AlekSi in FerretDB#2323 * Publish FerretDB v0.9.4 blog post by @Fashander in FerretDB#2268 * Use dashes instead of underscores or spaces by @AlekSi in FerretDB#2329 * Update documentation sidebar by @Fashander in FerretDB#2347 * Update FerretDB descriptions by @AlekSi in FerretDB#2281 * Improve flags documentation by @AlekSi in FerretDB#2331 * Describe supported fields for `$collStats` aggregation stage by @rumyantseva in FerretDB#2352 * Use iterators for `sort`, `limit`, `skip`, and `projection` by @AlekSi in FerretDB#2254 * Bump dependencies by @AlekSi in FerretDB#2307 * Improve resource tracking by @AlekSi in FerretDB#2319 * Add tests for `find`'s and `count`'s `skip` argument by @w84thesun in FerretDB#2325 * Close iterator properly by @AlekSi in FerretDB#2333 * Improve large numbers initialization in test data by @noisersup in FerretDB#2324 * Ignore `unique` index option for now by @AlekSi in FerretDB#2350 All closed issues and pull requests: https://github.com/FerretDB/FerretDB/milestone/39?closed=1 All commits: FerretDB/FerretDB@v0.9.4...v1.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1509.
createIndexescommand #2271.createIndexesanddropIndexes#2311.Readiness checklist
task all, and it passed.@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.