Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial setup of hana handler #2071

Merged
merged 12 commits into from
Mar 2, 2023
Merged

Initial setup of hana handler #2071

merged 12 commits into from
Mar 2, 2023

Conversation

lucboj
Copy link
Contributor

@lucboj lucboj commented Feb 28, 2023 •
edited by AlekSi
Loading

Description

This is the initial setup for the hana handler. It only copied the files from the dummy handler to the hana handler. No real changes were made besides adding the right package name in the files and fixing linting.

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@lucboj lucboj requested a review from a team as a code owner February 28, 2023 17:32
@CLAassistant
Copy link

CLAassistant commented Feb 28, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Feb 28, 2023 •
edited
Loading

Codecov Report

Merging #2071 (72ffa2d) into main (989c640) will decrease coverage by 0.54%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2071      +/-   ##
==========================================
- Coverage   56.27%   55.73%   -0.54%     
==========================================
  Files         321      362      +41     
  Lines       16274    16373      +99     
==========================================
- Hits         9158     9126      -32     
- Misses       6279     6409     +130     
- Partials      837      838       +1
Impacted Files Coverage Δ
internal/handlers/hana/cmd_query.go 0.00% <0.00%> (ø)
internal/handlers/hana/hana.go 0.00% <0.00%> (ø)
internal/handlers/hana/msg_aggregate.go 0.00% <0.00%> (ø)
internal/handlers/hana/msg_buildinfo.go 0.00% <0.00%> (ø)
internal/handlers/hana/msg_collmod.go 0.00% <0.00%> (ø)
internal/handlers/hana/msg_collstats.go 0.00% <0.00%> (ø)
internal/handlers/hana/msg_connectionstatus.go 0.00% <0.00%> (ø)
internal/handlers/hana/msg_count.go 0.00% <0.00%> (ø)
internal/handlers/hana/msg_create.go 0.00% <0.00%> (ø)
internal/handlers/hana/msg_createindexes.go 0.00% <0.00%> (ø)
... and 36 more
Flag Coverage Δ
integration 45.39% <ø> (ø)
mongodb 5.51% <ø> (ø)
tigris 45.15% <ø> (ø)
unit 27.44% <0.00%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

AlekSi
AlekSi requested changes Mar 1, 2023
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's call the package hana because we already have references to this name.

Please also check task lint results.

@AlekSi
Copy link
Member

AlekSi commented Mar 1, 2023

@lucboj Please click CLA button in this comment

@AlekSi AlekSi changed the title Initial setup of 'hana' handler Initial setup of hana handler Mar 1, 2023
@AlekSi AlekSi added the code/chore Code maintenance improvements label Mar 1, 2023
@AlekSi AlekSi self-assigned this Mar 1, 2023
@AlekSi AlekSi added this to the v1.0.0 GA milestone Mar 1, 2023
@lucboj
Copy link
Contributor Author

lucboj commented Mar 2, 2023

@AlekSi I have made your changes.

For the next PRs, would you want us to first create issues for what we want to change?

@AlekSi
Copy link
Member

AlekSi commented Mar 2, 2023

No, no issues are necessary. But please join our community Slack

@AlekSi
Copy link
Member

AlekSi commented Mar 2, 2023

I have made your changes.

CleanShot 2023-03-02 at 18 28 39@2x

Please click this button to re-request review

@lucboj lucboj requested review from AlekSi and removed request for w84thesun, rumyantseva and chilagrow March 2, 2023 14:50
@AlekSi AlekSi enabled auto-merge (squash) March 2, 2023 15:11
@AlekSi AlekSi requested review from a team, w84thesun, rumyantseva, chilagrow and noisersup March 2, 2023 15:14
@AlekSi AlekSi merged commit 092fbff into FerretDB:main Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w84thesun w84thesun w84thesun approved these changes

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva was automatically assigned from FerretDB/core

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow was automatically assigned from FerretDB/core

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
None yet
Milestone
v0.9.3
Development

Successfully merging this pull request may close these issues.
4 participants
@lucboj @CLAassistant @AlekSi @w84thesun