Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support $rename field update operator #1753

Merged
merged 48 commits into from
Jan 13, 2023
Merged

Support $rename field update operator #1753

merged 48 commits into from
Jan 13, 2023

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Jan 4, 2023 •
edited
Loading

Description

Closes #626.

Readiness checklist

  • I added unit tests for new functionality or bug fixes.
  • I added integration tests for new functionality or bug fixes.
  • I added compatibility tests for new functionality or bug fixes.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@vercel
Copy link

vercel bot commented Jan 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Jan 12, 2023 at 3:48PM (UTC)

@noisersup noisersup self-assigned this Jan 4, 2023
@vercel vercel bot temporarily deployed to Preview January 4, 2023 18:18 Inactive
@codecov
Copy link

codecov bot commented Jan 4, 2023 •
edited
Loading

Codecov Report

Merging #1753 (168ce98) into main (3c1a9fe) will increase coverage by 8.21%.
The diff coverage is 92.24%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1753      +/-   ##
==========================================
+ Coverage   61.12%   69.34%   +8.21%     
==========================================
  Files         307      307              
  Lines       14597    14711     +114     
==========================================
+ Hits         8923    10201    +1278     
+ Misses       4846     3546    -1300     
- Partials      828      964     +136
Impacted Files Coverage Δ
internal/handlers/common/error.go 73.33% <ø> (ø)
internal/handlers/common/errorcode_string.go 80.00% <ø> (ø)
internal/handlers/common/update.go 87.02% <89.89%> (+0.73%) ⬆️
integration/shareddata/scalars.go 100.00% <100.00%> (ø)
internal/types/path.go 94.17% <100.00%> (+0.42%) ⬆️
build/version/version.go 63.01% <0.00%> (-4.11%) ⬇️
internal/handlers/common/filter.go 85.20% <0.00%> (ø)
integration/helpers.go 78.73% <0.00%> (+0.45%) ⬆️
internal/clientconn/listener.go 77.04% <0.00%> (+1.53%) ⬆️
internal/handlers/tigris/tjson/schema.go 81.52% <0.00%> (+1.63%) ⬆️
... and 47 more
Flag Coverage Δ
integration 65.36% <92.24%> (+11.70%) ⬆️
mongodb 14.66% <0.77%> (-0.10%) ⬇️
pg 53.98% <92.24%> (+0.40%) ⬆️
tigris 43.20% <77.51%> (?)
unit 28.88% <8.59%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@vercel vercel bot temporarily deployed to Preview January 5, 2023 16:43 Inactive
@vercel vercel bot temporarily deployed to Preview January 5, 2023 18:37 Inactive
@vercel vercel bot temporarily deployed to Preview January 5, 2023 22:22 Inactive
@vercel vercel bot temporarily deployed to Preview January 5, 2023 23:00 Inactive
@vercel vercel bot temporarily deployed to Preview January 6, 2023 00:09 Inactive
@vercel vercel bot temporarily deployed to Preview January 6, 2023 00:48 Inactive
@vercel vercel bot temporarily deployed to Preview January 6, 2023 01:40 Inactive
@noisersup noisersup added the code/feature Some user-visible feature is not implemented yet label Jan 6, 2023
@noisersup noisersup marked this pull request as ready for review January 6, 2023 03:15
@noisersup noisersup requested a review from a team as a code owner January 6, 2023 03:15
@vercel vercel bot temporarily deployed to Preview January 12, 2023 09:08 Inactive
w84thesun
w84thesun previously approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

rumyantseva
rumyantseva reviewed Jan 12, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of comments about lines that codecov reported

internal/handlers/common/update.go Show resolved Hide resolved
internal/handlers/common/update.go Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview January 12, 2023 12:26 Inactive
rumyantseva
rumyantseva approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vercel vercel bot temporarily deployed to Preview January 12, 2023 14:37 Inactive
w84thesun
w84thesun suggested changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, just one small fix left!

internal/handlers/common/update.go Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview January 12, 2023 15:48 Inactive
@noisersup noisersup requested a review from w84thesun January 12, 2023 15:49
@noisersup noisersup merged commit 41fe3d5 into FerretDB:main Jan 13, 2023
@noisersup noisersup deleted the rename-update-operator-626 branch January 13, 2023 09:58
@rumyantseva rumyantseva mentioned this pull request Jan 13, 2023
Closed
@AlekSi AlekSi added this to the v0.8.1 milestone Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun w84thesun approved these changes

@AlekSi AlekSi AlekSi approved these changes

Assignees

@noisersup noisersup

Labels
code/feature Some user-visible feature is not implemented yet
Projects
None yet
Milestone
v0.8.1
Development

Successfully merging this pull request may close these issues.

Support $rename field update operator
5 participants
@noisersup @AlekSi @w84thesun @rumyantseva @chilagrow