Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic benchmark for query pushdowns #1689

Merged
merged 12 commits into from
Dec 28, 2022
Merged

Add basic benchmark for query pushdowns #1689

merged 12 commits into from
Dec 28, 2022

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Dec 23, 2022 •
edited
Loading

Description

This one was created for the blogpost. As agreed it doesn't run on any external data and will be modified in the future.
As I'm not sure if it met requirements, @AlekSi PTAL.

Readiness checklist

  • I added unit tests for new functionality or bugfixes.
  • I added integration tests for new functionality or bugfixes.
  • I added compatibility tests for new functionality or bugfixes.
  • I made spot refactoring.
  • I updated the documentation.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@noisersup noisersup added code/chore Code maintenance improvements do not merge PRs that should not be merged labels Dec 23, 2022
@noisersup noisersup self-assigned this Dec 23, 2022
@noisersup noisersup requested a review from a team as a code owner December 23, 2022 11:22
@vercel
Copy link

vercel bot commented Dec 23, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Dec 28, 2022 at 8:53AM (UTC)

@noisersup noisersup requested review from a team and chilagrow and removed request for a team December 23, 2022 11:22
@vercel vercel bot temporarily deployed to Preview December 23, 2022 11:24 Inactive
AlekSi
AlekSi requested changes Dec 23, 2022
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark has to use b.N: https://pkg.go.dev/testing#hdr-Benchmarks

@codecov
Copy link

codecov bot commented Dec 23, 2022 •
edited
Loading

Codecov Report

Merging #1689 (f84baf9) into main (fed0319) will decrease coverage by 0.11%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1689      +/-   ##
==========================================
- Coverage   69.39%   69.28%   -0.12%     
==========================================
  Files         300      300              
  Lines       14067    14067              
==========================================
- Hits         9762     9746      -16     
- Misses       3380     3399      +19     
+ Partials      925      922       -3
Impacted Files Coverage Δ
internal/handlers/tigris/tigrisdb/errors.go 21.42% <0.00%> (-21.43%) ⬇️
internal/handlers/tigris/msg_create.go 67.60% <0.00%> (-7.05%) ⬇️
internal/handlers/tigris/tigrisdb/collections.go 61.90% <0.00%> (-4.77%) ⬇️
internal/util/version/version.go 70.58% <0.00%> (-4.42%) ⬇️
internal/handlers/common/filter.go 84.86% <0.00%> (ø)
Flag Coverage Δ
integration 65.07% <ø> (-0.12%) ⬇️
mongodb 14.36% <ø> (-0.01%) ⬇️
pg 54.22% <ø> (-0.03%) ⬇️
tigris 38.98% <ø> (-0.12%) ⬇️
unit 29.12% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@vercel vercel bot temporarily deployed to Preview December 23, 2022 12:23 Inactive
@vercel vercel bot temporarily deployed to Preview December 23, 2022 12:46 Inactive
@noisersup noisersup enabled auto-merge (squash) December 23, 2022 12:47
@noisersup noisersup requested a review from AlekSi December 23, 2022 12:47
@vercel vercel bot temporarily deployed to Preview December 23, 2022 17:42 Inactive
@vercel vercel bot temporarily deployed to Preview December 25, 2022 20:07 Inactive
@vercel vercel bot temporarily deployed to Preview December 25, 2022 23:09 Inactive
@noisersup noisersup requested a review from chilagrow December 27, 2022 06:23
chilagrow
chilagrow previously approved these changes Dec 27, 2022
View reviewed changes
@AlekSi AlekSi added this to the v0.8.0 Beta milestone Dec 27, 2022
@vercel vercel bot temporarily deployed to Preview December 27, 2022 09:54 Inactive
rumyantseva
rumyantseva suggested changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, NoPushdown does a pushdown :)

integration/benchmarks_test.go Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview December 27, 2022 11:47 Inactive
rumyantseva
rumyantseva previously approved these changes Dec 27, 2022
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vercel vercel bot temporarily deployed to Preview December 27, 2022 19:26 Inactive
rumyantseva
rumyantseva approved these changes Dec 28, 2022
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vercel vercel bot temporarily deployed to Preview December 28, 2022 08:21 Inactive
@vercel vercel bot temporarily deployed to Preview December 28, 2022 08:53 Inactive
@AlekSi AlekSi removed the do not merge PRs that should not be merged label Dec 28, 2022
@AlekSi AlekSi changed the title Init benchmark for query pushdowns Add basic benchmark for query pushdowns Dec 28, 2022
@noisersup noisersup merged commit c50e834 into FerretDB:main Dec 28, 2022
@noisersup noisersup deleted the benchmark-pushdowns branch December 28, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@AlekSi AlekSi AlekSi approved these changes

@w84thesun w84thesun Awaiting requested review from w84thesun w84thesun is a code owner automatically assigned from FerretDB/leads

Assignees

@noisersup noisersup

Labels
code/chore Code maintenance improvements
Projects
None yet
Milestone
v0.8.0 Beta
Development

Successfully merging this pull request may close these issues.
4 participants
@noisersup @AlekSi @rumyantseva @chilagrow