Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SchemaStats to return empty stats #1359

Merged
merged 31 commits into from
Nov 9, 2022
Merged

Fix SchemaStats to return empty stats #1359

merged 31 commits into from
Nov 9, 2022

Conversation

w84thesun
Copy link
Contributor

@w84thesun w84thesun commented Nov 2, 2022 •
edited by rumyantseva
Loading

Description

Closes #1317.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@vercel
Copy link

vercel bot commented Nov 2, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Nov 9, 2022 at 10:10AM (UTC)

@w84thesun w84thesun self-assigned this Nov 2, 2022
@w84thesun w84thesun added the code/bug Some user-visible feature works incorrectly label Nov 2, 2022
@w84thesun w84thesun added this to the v0.6.1 milestone Nov 2, 2022
@vercel vercel bot temporarily deployed to Preview November 2, 2022 16:33 Inactive
@vercel vercel bot temporarily deployed to Preview November 3, 2022 12:32 Inactive
@w84thesun w84thesun changed the title Fix SchemaStats Remove SchemaStats response Nov 4, 2022
@vercel vercel bot temporarily deployed to Preview November 4, 2022 08:32 Inactive
@vercel vercel bot temporarily deployed to Preview November 4, 2022 09:29 Inactive
@vercel vercel bot temporarily deployed to Preview November 4, 2022 10:05 Inactive
@vercel vercel bot temporarily deployed to Preview November 8, 2022 10:29 Inactive
@rumyantseva rumyantseva marked this pull request as ready for review November 8, 2022 10:35
@rumyantseva rumyantseva requested a review from a team as a code owner November 8, 2022 10:35
@rumyantseva rumyantseva requested review from AlekSi, rumyantseva, a team, chilagrow and noisersup and removed request for a team November 8, 2022 10:35
@rumyantseva rumyantseva enabled auto-merge (squash) November 8, 2022 10:35
@vercel vercel bot temporarily deployed to Preview November 8, 2022 11:51 Inactive
noisersup
noisersup previously approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We could comment the serverStatus code and attach a "TODO", instead of deleting it completely though. The code will be probably reused in the future if I understand.

AlekSi
AlekSi previously approved these changes Nov 9, 2022
View reviewed changes
@rumyantseva rumyantseva dismissed stale reviews from AlekSi and noisersup via fca25fe November 9, 2022 08:39
@vercel vercel bot temporarily deployed to Preview November 9, 2022 08:40 Inactive
@vercel vercel bot temporarily deployed to Preview November 9, 2022 10:10 Inactive
@rumyantseva rumyantseva merged commit 9e34c24 into FerretDB:main Nov 9, 2022
@w84thesun w84thesun deleted the issue-1317-fix-schema-stats branch November 28, 2022 11:06
AlekSi added a commit to AlekSi/FerretDB that referenced this pull request Mar 29, 2023
@AlekSi
Add partial schema stats
cb7f46b 
Partially reverts FerretDB#1317 / FerretDB#1359.
Refs FerretDB#1346.
@AlekSi AlekSi mentioned this pull request Mar 29, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@AlekSi AlekSi AlekSi approved these changes

@rumyantseva rumyantseva Awaiting requested review from rumyantseva rumyantseva is a code owner automatically assigned from FerretDB/leads

@noisersup noisersup Awaiting requested review from noisersup

Assignees

@rumyantseva rumyantseva

Labels
code/bug Some user-visible feature works incorrectly
Projects
None yet
Milestone
v0.6.2
Development

Successfully merging this pull request may close these issues.

Fix SchemaStats to return empty stats (so tests won't fail)
5 participants
@w84thesun @AlekSi @rumyantseva @chilagrow @noisersup