Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A minor clarification about diff tests #1339

Merged
merged 3 commits into from
Oct 28, 2022
Merged

A minor clarification about diff tests #1339

merged 3 commits into from
Oct 28, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 27, 2022

Description

For everyone to agree.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi requested review from a team and Fashander October 27, 2022 15:26
@vercel
Copy link

vercel bot commented Oct 27, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Oct 28, 2022 at 11:50AM (UTC)

@AlekSi AlekSi requested review from a team, w84thesun, rumyantseva, chilagrow and noisersup and removed request for a team October 27, 2022 15:26
@AlekSi AlekSi self-assigned this Oct 27, 2022
@AlekSi AlekSi added code/chore Code maintenance improvements do not merge PRs that should not be merged labels Oct 27, 2022
@AlekSi AlekSi added this to the v0.6.1 milestone Oct 27, 2022
@AlekSi AlekSi enabled auto-merge (squash) October 27, 2022 15:26
@vercel vercel bot temporarily deployed to Preview October 27, 2022 15:27 Inactive
@vercel vercel bot temporarily deployed to Preview October 27, 2022 15:35 Inactive
@codecov
Copy link

codecov bot commented Oct 27, 2022 •
edited
Loading

Codecov Report

Merging #1339 (f6153bd) into main (05be2d5) will increase coverage by 20.48%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1339       +/-   ##
===========================================
+ Coverage   46.60%   67.09%   +20.48%     
===========================================
  Files         279      279               
  Lines       13134    13134               
===========================================
+ Hits         6121     8812     +2691     
+ Misses       6276     3397     -2879     
- Partials      737      925      +188
Impacted Files Coverage Δ
internal/util/version/version.go 48.52% <0.00%> (-4.42%) ⬇️
internal/clientconn/conn.go 44.70% <0.00%> (+0.68%) ⬆️
integration/helpers.go 87.23% <0.00%> (+1.06%) ⬆️
internal/handlers/pg/pgdb/collections.go 50.00% <0.00%> (+2.27%) ⬆️
internal/handlers/pg/pgdb/settings.go 39.53% <0.00%> (+2.32%) ⬆️
internal/handlers/pg/pgdb/tables.go 64.70% <0.00%> (+2.94%) ⬆️
internal/handlers/pg/pgdb/databases.go 55.00% <0.00%> (+5.00%) ⬆️
internal/handlers/common/limit.go 75.00% <0.00%> (+8.33%) ⬆️
internal/types/document.go 88.04% <0.00%> (+9.78%) ⬆️
internal/handlers/common/typecode.go 94.73% <0.00%> (+11.84%) ⬆️
... and 49 more
Flag Coverage Δ
integration 63.18% <ø> (+25.90%) ⬆️
mongodb 14.29% <ø> (-0.01%) ⬇️
pg 52.75% <ø> (?)
tigris 34.63% <ø> (-0.03%) ⬇️
unit 26.04% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

rumyantseva
rumyantseva approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@AlekSi AlekSi removed the do not merge PRs that should not be merged label Oct 28, 2022
@AlekSi
Copy link
Member Author

AlekSi commented Oct 28, 2022

@Fashander PTAL

@vercel vercel bot temporarily deployed to Preview October 28, 2022 11:50 Inactive
@AlekSi
Copy link
Member Author

AlekSi commented Oct 28, 2022

@Fashander PTAL

@AlekSi AlekSi merged commit 01031f8 into FerretDB:main Oct 28, 2022
@AlekSi AlekSi deleted the clarify branch October 28, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@Fashander Fashander Fashander approved these changes

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun w84thesun approved these changes

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
None yet
Milestone
v0.6.1
Development

Successfully merging this pull request may close these issues.
6 participants
@AlekSi @w84thesun @rumyantseva @chilagrow @Fashander @noisersup