Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make users know about telemetry via startupWarnings #1336

Merged
merged 29 commits into from
Nov 2, 2022
Merged

Make users know about telemetry via startupWarnings #1336

merged 29 commits into from
Nov 2, 2022

Conversation

rumyantseva
Copy link
Contributor

@rumyantseva rumyantseva commented Oct 27, 2022 •
edited
Loading

Description

Closes #1328.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@rumyantseva rumyantseva self-assigned this Oct 27, 2022
@vercel
Copy link

vercel bot commented Oct 27, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Nov 2, 2022 at 1:57AM (UTC)

@vercel vercel bot temporarily deployed to Preview October 27, 2022 10:34 Inactive
@vercel vercel bot temporarily deployed to Preview October 27, 2022 10:35 Inactive
@codecov
Copy link

codecov bot commented Oct 27, 2022 •
edited
Loading

Codecov Report

Merging #1336 (846d839) into main (5c242d0) will increase coverage by 20.52%.
The diff coverage is 95.34%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1336       +/-   ##
===========================================
+ Coverage   47.05%   67.57%   +20.52%     
===========================================
  Files         279      279               
  Lines       13174    13200       +26     
===========================================
+ Hits         6199     8920     +2721     
+ Misses       6234     3353     -2881     
- Partials      741      927      +186
Impacted Files Coverage Δ
internal/util/telemetry/reporter.go 0.00% <0.00%> (ø)
integration/setup/common.go 93.89% <100.00%> (ø)
integration/setup/setup.go 87.03% <100.00%> (+0.24%) ⬆️
integration/setup/setup_compat.go 86.61% <100.00%> (+0.21%) ⬆️
internal/handlers/pg/msg_getlog.go 81.25% <100.00%> (+81.25%) ⬆️
internal/handlers/tigris/msg_getlog.go 78.35% <100.00%> (+2.76%) ⬆️
internal/util/version/version.go 48.52% <0.00%> (-4.42%) ⬇️
internal/clientconn/conn.go 44.70% <0.00%> (+0.68%) ⬆️
integration/helpers.go 87.23% <0.00%> (+1.06%) ⬆️
internal/handlers/pg/pgdb/settings.go 41.35% <0.00%> (+2.25%) ⬆️
... and 56 more
Flag Coverage Δ
integration 63.68% <100.00%> (+25.86%) ⬆️
mongodb 14.20% <12.19%> (+<0.01%) ⬆️
pg 52.83% <63.41%> (?)
tigris 35.22% <63.41%> (+0.02%) ⬆️
unit 26.01% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@vercel vercel bot temporarily deployed to Preview October 27, 2022 12:39 Inactive
@vercel vercel bot temporarily deployed to Preview October 27, 2022 12:50 Inactive
@vercel vercel bot temporarily deployed to Preview October 27, 2022 12:52 Inactive
@rumyantseva rumyantseva added the code/enhancement Some user-visible feature could work better label Oct 27, 2022
@rumyantseva rumyantseva marked this pull request as ready for review October 27, 2022 12:57
@rumyantseva rumyantseva requested a review from a team as a code owner October 27, 2022 12:57
@rumyantseva rumyantseva requested review from AlekSi, w84thesun, a team, chilagrow and noisersup and removed request for a team October 27, 2022 12:57
@vercel vercel bot temporarily deployed to Preview October 27, 2022 13:18 Inactive
@vercel vercel bot temporarily deployed to Preview October 27, 2022 13:24 Inactive
@vercel vercel bot temporarily deployed to Preview October 31, 2022 11:19 Inactive
noisersup
noisersup requested changes Oct 31, 2022
View reviewed changes
Copy link
Member

@noisersup noisersup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, although mongodb tests are failing and they don't look flaky

@rumyantseva
Copy link
Contributor Author

@noisersup nice catch!

w84thesun
w84thesun previously approved these changes Oct 31, 2022
View reviewed changes
@vercel vercel bot temporarily deployed to Preview October 31, 2022 13:16 Inactive
@vercel vercel bot temporarily deployed to Preview October 31, 2022 18:57 Inactive
@rumyantseva rumyantseva mentioned this pull request Oct 31, 2022
Closed
AlekSi
AlekSi reviewed Nov 1, 2022
View reviewed changes
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1336 (comment)

@vercel vercel bot temporarily deployed to Preview November 1, 2022 10:12 Inactive
@vercel vercel bot temporarily deployed to Preview November 1, 2022 13:29 Inactive
@vercel vercel bot temporarily deployed to Preview November 1, 2022 17:54 Inactive
@vercel vercel bot temporarily deployed to Preview November 2, 2022 01:57 Inactive
@rumyantseva rumyantseva merged commit be83096 into FerretDB:main Nov 2, 2022
@rumyantseva rumyantseva deleted the issue-1328-strtup-warnings-telem branch November 2, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noisersup noisersup noisersup approved these changes

@chilagrow chilagrow chilagrow approved these changes

@w84thesun w84thesun w84thesun approved these changes

@AlekSi AlekSi Awaiting requested review from AlekSi

Assignees

@rumyantseva rumyantseva

Labels
code/enhancement Some user-visible feature could work better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make users know about telemetry via startupWarnings
5 participants
@rumyantseva @AlekSi @w84thesun @chilagrow @noisersup