Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand debugError stub #1303

Merged
merged 4 commits into from
Oct 24, 2022
Merged

Expand debugError stub #1303

merged 4 commits into from
Oct 24, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 23, 2022 •
edited
Loading

Description

Refs #640.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi self-assigned this Oct 23, 2022
@vercel
Copy link

vercel bot commented Oct 23, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Oct 24, 2022 at 8:08AM (UTC)

@AlekSi AlekSi added this to the v0.6.0 Alpha milestone Oct 23, 2022
@vercel vercel bot temporarily deployed to Preview October 23, 2022 17:44 Inactive
@AlekSi AlekSi added the code/chore Code maintenance improvements label Oct 24, 2022
@AlekSi AlekSi marked this pull request as ready for review October 24, 2022 04:58
@AlekSi AlekSi requested a review from a team as a code owner October 24, 2022 04:58
@AlekSi AlekSi enabled auto-merge (squash) October 24, 2022 04:58
@AlekSi AlekSi requested review from a team, chilagrow and noisersup and removed request for a team October 24, 2022 04:58
@AlekSi AlekSi requested a review from chilagrow October 24, 2022 06:06
@vercel vercel bot temporarily deployed to Preview October 24, 2022 06:08 Inactive
@codecov
Copy link

codecov bot commented Oct 24, 2022 •
edited
Loading

Codecov Report

Merging #1303 (0d9bf29) into main (fc12d29) will increase coverage by 20.87%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1303       +/-   ##
===========================================
+ Coverage   46.97%   67.85%   +20.87%     
===========================================
  Files         275      275               
  Lines       12877    12888       +11     
===========================================
+ Hits         6049     8745     +2696     
+ Misses       6101     3220     -2881     
- Partials      727      923      +196
Impacted Files Coverage Δ
internal/handlers/common/msg_debugerror.go 0.00% <0.00%> (ø)
internal/util/version/version.go 48.52% <0.00%> (-4.42%) ⬇️
internal/clientconn/conn.go 44.01% <0.00%> (+0.70%) ⬆️
integration/helpers.go 87.23% <0.00%> (+1.06%) ⬆️
internal/handlers/pg/pgdb/collections.go 50.00% <0.00%> (+2.27%) ⬆️
internal/handlers/pg/pgdb/tables.go 64.70% <0.00%> (+2.94%) ⬆️
internal/handlers/pg/pgdb/databases.go 55.00% <0.00%> (+5.00%) ⬆️
internal/handlers/pg/pgdb/settings.go 44.18% <0.00%> (+6.97%) ⬆️
internal/handlers/common/limit.go 75.00% <0.00%> (+8.33%) ⬆️
... and 51 more
Flag Coverage Δ
integration 63.26% <0.00%> (+26.05%) ⬆️
mongodb 14.14% <0.00%> (-0.02%) ⬇️
pg 52.79% <0.00%> (?)
tigris 34.54% <0.00%> (-0.06%) ⬇️
unit 25.68% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi
Copy link
Member Author

AlekSi commented Oct 24, 2022

@chilagrow PTAL

chilagrow
chilagrow approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@chilagrow chilagrow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 the part that requires implementation is clear

@vercel vercel bot temporarily deployed to Preview October 24, 2022 08:00 Inactive
@vercel vercel bot temporarily deployed to Preview October 24, 2022 08:08 Inactive
rumyantseva
rumyantseva approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a draft to me. If the purpose of it was to have a draft, LGTM. Otherwise, doesn't seem to be ready (doesn't do what the task describes etc)

@AlekSi AlekSi merged commit fcf3fbd into FerretDB:main Oct 24, 2022
@AlekSi AlekSi deleted the debug-error branch October 24, 2022 09:03
@AlekSi
Copy link
Member Author

AlekSi commented Oct 24, 2022

It does not close the issue. It wasn't intended for that issue to do that. That's also not a draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chilagrow chilagrow chilagrow approved these changes

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun Awaiting requested review from w84thesun w84thesun is a code owner automatically assigned from FerretDB/leads

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/chore Code maintenance improvements
Projects
None yet
Milestone
v0.6.0 Alpha
Development

Successfully merging this pull request may close these issues.
3 participants
@AlekSi @rumyantseva @chilagrow