Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UUID to Prometheus metrics if requested #1240

Merged
merged 16 commits into from
Oct 12, 2022
Merged

Add UUID to Prometheus metrics if requested #1240

merged 16 commits into from
Oct 12, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Oct 11, 2022 •
edited
Loading

Description

Closes #1209.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.
  • I added/updated comments for both exported and unexported top-level declarations (functions, types, etc).
  • I checked comments rendering with task godocs.
  • I ensured that the title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added code/enhancement Some user-visible feature could work better do not merge PRs that should not be merged labels Oct 11, 2022
@AlekSi AlekSi added this to the v0.6.0 Alpha milestone Oct 11, 2022
@AlekSi AlekSi self-assigned this Oct 11, 2022
@vercel
Copy link

vercel bot commented Oct 11, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ferret-db ✅ Ready (Inspect) Visit Preview Oct 12, 2022 at 4:53PM (UTC)

@vercel vercel bot temporarily deployed to Preview October 11, 2022 14:11 Inactive
@codecov
Copy link

codecov bot commented Oct 11, 2022 •
edited
Loading

Codecov Report

Merging #1240 (1e16151) into main (ddaee74) will decrease coverage by 0.15%.
The diff coverage is 87.09%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1240      +/-   ##
==========================================
- Coverage   66.50%   66.35%   -0.16%     
==========================================
  Files         268      269       +1     
  Lines       12881    12904      +23     
==========================================
- Hits         8567     8562       -5     
- Misses       3376     3395      +19     
- Partials      938      947       +9
Impacted Files Coverage Δ
internal/clientconn/conn.go 44.01% <0.00%> (ø)
internal/clientconn/listener.go 76.28% <ø> (ø)
integration/setup/common.go 93.22% <100.00%> (ø)
internal/util/debug/debug.go 82.85% <100.00%> (ø)
internal/util/state/metrics.go 100.00% <100.00%> (ø)
internal/util/state/provider.go 80.43% <100.00%> (ø)
internal/clientconn/conninfo/conn_info.go 66.66% <0.00%> (-16.67%) ⬇️
internal/util/version/version.go 48.52% <0.00%> (-4.42%) ⬇️
internal/handlers/pg/pgdb/query.go 51.41% <0.00%> (-2.83%) ⬇️
internal/handlers/common/filter.go 86.58% <0.00%> (-1.89%) ⬇️
Flag Coverage Δ
integration 61.06% <50.00%> (-0.17%) ⬇️
mongodb 13.80% <50.00%> (-0.03%) ⬇️
pg 50.83% <50.00%> (-0.17%) ⬇️
tigris 32.91% <50.00%> (-0.10%) ⬇️
unit 25.84% <76.66%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@vercel vercel bot temporarily deployed to Preview October 11, 2022 15:25 Inactive
@vercel vercel bot temporarily deployed to Preview October 11, 2022 16:40 Inactive
@AlekSi AlekSi removed the do not merge PRs that should not be merged label Oct 11, 2022
@vercel vercel bot temporarily deployed to Preview October 11, 2022 18:13 Inactive
@vercel vercel bot temporarily deployed to Preview October 11, 2022 18:21 Inactive
@vercel vercel bot temporarily deployed to Preview October 12, 2022 07:03 Inactive
@vercel vercel bot temporarily deployed to Preview October 12, 2022 07:11 Inactive
@vercel vercel bot temporarily deployed to Preview October 12, 2022 07:42 Inactive
@AlekSi AlekSi changed the title Add UUID to metrics Add UUID to Prometheus metrics if requested Oct 12, 2022
@AlekSi AlekSi marked this pull request as ready for review October 12, 2022 15:01
@AlekSi AlekSi requested a review from a team as a code owner October 12, 2022 15:01
@AlekSi AlekSi enabled auto-merge (squash) October 12, 2022 15:01
@AlekSi AlekSi requested review from a team, chilagrow and noisersup and removed request for a team October 12, 2022 15:02
@vercel vercel bot temporarily deployed to Preview October 12, 2022 15:02 Inactive
w84thesun
w84thesun suggested changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter fails

@AlekSi
Copy link
Member Author

AlekSi commented Oct 12, 2022

doh, that was "last minute fix" 😆

@AlekSi AlekSi requested review from w84thesun and a team October 12, 2022 16:40
@vercel vercel bot temporarily deployed to Preview October 12, 2022 16:41 Inactive
@vercel vercel bot temporarily deployed to Preview October 12, 2022 16:53 Inactive
w84thesun
w84thesun approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@w84thesun w84thesun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rumyantseva
rumyantseva approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlekSi AlekSi merged commit 2d36608 into FerretDB:main Oct 12, 2022
@AlekSi AlekSi deleted the uuid-metrics branch October 12, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumyantseva rumyantseva rumyantseva approved these changes

@w84thesun w84thesun w84thesun approved these changes

@chilagrow chilagrow Awaiting requested review from chilagrow chilagrow was automatically assigned from FerretDB/core

@noisersup noisersup Awaiting requested review from noisersup noisersup was automatically assigned from FerretDB/core

Assignees

@AlekSi AlekSi

Labels
code/enhancement Some user-visible feature could work better
Projects
None yet
Milestone
v0.6.0 Alpha
Development

Successfully merging this pull request may close these issues.

Add UUID to metrics
3 participants
@AlekSi @w84thesun @rumyantseva