Add TODOs (#852)

FerretDB · Jul 7, 2022 · ced68a5 · ced68a5
1 parent 979bb25
commit ced68a5
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/internal/handlers/pg/msg_delete.go b/internal/handlers/pg/msg_delete.go
@@ -32,10 +32,12 @@ func (h *Handler) MsgDelete(ctx context.Context, msg *wire.OpMsg) (*wire.OpMsg,
 		return nil, lazyerrors.Error(err)
 	}
 
+	common.Ignored(document, h.l, "comment") // TODO https://github.com/FerretDB/FerretDB/issues/849
 	if err := common.Unimplemented(document, "let"); err != nil {
 		return nil, err
 	}
-	common.Ignored(document, h.l, "ordered", "writeConcern")
+	common.Ignored(document, h.l, "ordered") // TODO https://github.com/FerretDB/FerretDB/issues/848
+	common.Ignored(document, h.l, "writeConcern")
 
 	var deletes *types.Array
 	if deletes, err = common.GetOptionalParam(document, "deletes", deletes); err != nil {
@@ -49,7 +51,7 @@ func (h *Handler) MsgDelete(ctx context.Context, msg *wire.OpMsg) (*wire.OpMsg,
 			return nil, err
 		}
 
-		if err := common.Unimplemented(d, "collation", "hint", "comment"); err != nil {
+		if err := common.Unimplemented(d, "collation", "hint"); err != nil {
 			return nil, err
 		}
 

diff --git a/internal/handlers/pg/pg.go b/internal/handlers/pg/pg.go
@@ -26,8 +26,7 @@ import (
 
 // Handler implements handlers.Interface on top of PostgreSQL.
 type Handler struct {
-	// TODO replace those fields with
-	// opts *NewOpts
+	// TODO replace those fields with embedded *NewOpts to sync with Tigris handler
 	pgPool    *pgdb.Pool
 	l         *zap.Logger
 	startTime time.Time

diff --git a/internal/handlers/tigris/msg_delete.go b/internal/handlers/tigris/msg_delete.go
@@ -36,10 +36,12 @@ func (h *Handler) MsgDelete(ctx context.Context, msg *wire.OpMsg) (*wire.OpMsg,
 		return nil, lazyerrors.Error(err)
 	}
 
+	common.Ignored(document, h.L, "comment") // TODO https://github.com/FerretDB/FerretDB/issues/849
 	if err := common.Unimplemented(document, "let"); err != nil {
 		return nil, err
 	}
-	common.Ignored(document, h.L, "ordered", "writeConcern")
+	common.Ignored(document, h.L, "ordered") // TODO https://github.com/FerretDB/FerretDB/issues/848
+	common.Ignored(document, h.L, "writeConcern")
 
 	var deletes *types.Array
 	if deletes, err = common.GetOptionalParam(document, "deletes", deletes); err != nil {
@@ -53,7 +55,7 @@ func (h *Handler) MsgDelete(ctx context.Context, msg *wire.OpMsg) (*wire.OpMsg,
 			return nil, err
 		}
 
-		if err := common.Unimplemented(d, "collation", "hint", "comment"); err != nil {
+		if err := common.Unimplemented(d, "collation", "hint"); err != nil {
 			return nil, err
 		}