Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(T) improved, new implementations added #107

Merged
merged 43 commits into from
Oct 27, 2021
Merged

Conversation

gustavojra
Copy link
Member

  • New implementations using Octavian for (T) and DF-MP2
  • (T) Optimized
  • Macro for frozen core (it basically sets drop_occ for you based on the molecule found in the options)
  • tblis is now default to true
  • Molecules.jl is now integrated to the code and the corresponding code in Fermi has been removed.
  • Benchmarks used for the JCTC paper are in the benchmark folder, zipped away.

@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #107 (3ee4f66) into master (804b405) will decrease coverage by 8.94%.
The diff coverage is 35.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
- Coverage   72.44%   63.49%   -8.95%     
==========================================
  Files          36       41       +5     
  Lines        2943     3301     +358     
==========================================
- Hits         2132     2096      -36     
- Misses        811     1205     +394     
Impacted Files Coverage Δ
src/Backend/Libcint.jl 72.72% <0.00%> (-27.28%) ⬇️
src/Backend/Options.jl 100.00% <ø> (ø)
src/Core/AtomicIntegrals/OneElectron.jl 64.04% <0.00%> (ø)
src/Core/AtomicIntegrals/TwoElectronFourCenter.jl 99.02% <ø> (ø)
src/Core/AtomicIntegrals/TwoElectronThreeCenter.jl 100.00% <ø> (ø)
src/Core/AtomicIntegrals/TwoElectronTwoCenter.jl 100.00% <ø> (ø)
src/Core/ROIntegrals.jl 24.56% <ø> (-3.82%) ⬇️
src/Core/ROIntegrals/OneElectron.jl 0.00% <0.00%> (ø)
src/Methods/CoupledCluster/CoupledCluster.jl 100.00% <ø> (ø)
.../Methods/CoupledCluster/PerturbativeTriples/abc.jl 0.00% <0.00%> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 804b405...3ee4f66. Read the comment docs.

@gustavojra
Copy link
Member Author

I am merging this, but the coverage needs to be fixed (>70%) ASAP!!!!

@gustavojra gustavojra closed this Oct 27, 2021
@gustavojra gustavojra reopened this Oct 27, 2021
@gustavojra gustavojra merged commit 5751862 into FermiQC:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant