Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(*): add automatic retries to AtatClient::send implementation #124

Merged
merged 6 commits into from
Apr 11, 2022
Merged

feature(*): add automatic retries to AtatClient::send implementation #124

merged 6 commits into from
Apr 11, 2022

Conversation

MathiasKoch
Copy link
Member

@MathiasKoch MathiasKoch commented Apr 8, 2022 •
edited
Loading

Introduces a new auto-implemented send_retry() function to AtatClient, and a new associated const ATTEMPTS: u8 to AtatCmd.

When send_retry() is used instead of send(), it will automatically retry a command ATTEMPTS times, if the result is Err(Error::Timeout) | Err(Error::Parse)

Fixes #123

simonvandel
simonvandel reviewed Apr 8, 2022
View reviewed changes
atat/src/traits.rs Outdated Show resolved Hide resolved
atat/src/client.rs Outdated Show resolved Hide resolved
@MathiasKoch MathiasKoch merged commit a7716dd into master Apr 11, 2022
@MathiasKoch MathiasKoch deleted the feature/auto-retry branch April 11, 2022 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonvandel simonvandel simonvandel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for automatic command retry
2 participants
@MathiasKoch @simonvandel