Terminally deprecate EventFactory isProfilingEnabled and invalidate
#3050
Conversation
fabric-api-base/src/main/java/net/fabricmc/fabric/api/event/EventFactory.java
Outdated
Show resolved
Hide resolved
One of the nice things about the vanilla profile, that Spark/async-profiler don't make as easy, is that it can provides per-tick profiling data. This is very useful when trying to track down stutter/lag spikes. I've definitely benefitted from this feature in the past. That said, realise this does remove a lot of code, so it may not be worth keeping around just for that. |
|
Im not sure if anyone actully ever used this feature, there was no public API to enable it. I do think the vanilla profiling tools are under used (By players and modders), maybe there are things we can do to help increase its useage. Sampler can provider per tick profiles, and can also only trigger on ticks that take longer than a given time. |
fabric-api-base/src/main/java/net/fabricmc/fabric/api/event/EventFactory.java
Show resolved
Hide resolved
Was it not enabled by default? |
Ah, I just realized... Then it should maybe be set to |
|
Oh, apparenly it was enabled by default, my bad. I guess there is a small pref gain from this change then 👍 |
…ate` (#3050) * Terminally deprecate `EventFactory` `isProfilingEnabled` and `invalidate` * Remove `forRemoval` in `isProfiling` deprecation * Also deprecate
This functionality is useless clutter, using a proper profiler is much better.
Fixes #2849.