Renaming some of the types in Prims #2461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n the standard types currently defined in Pervasives etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames
c_Falsetoemptyc_Truetotrivialc_andtopairc_ortosummatching documentation in doc/book/part2
I tried to further streamline this by making
trivial = unit,pair = tuple2andsum = either, but that is much more difficult, mainly because these types are needed in the very first few lines of Prims, where it is not possible to define the hasEq axioms and discriminators/projectors for a type.With @aseemr , I discussed addressing that work in the future, where we could introduce these types early in Prims but defer the their hasEq and projectors until GTot is defined.