Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix embedding of ident (fixes #2444) #2445

Merged
merged 4 commits into from
Feb 14, 2022

Conversation

W95Psp
Copy link
Contributor

@W95Psp W95Psp commented Feb 4, 2022

No description provided.

@mtzguido
Copy link
Member

This looks good to me! Surprised it didn't pop up before. Thanks!

@W95Psp
Copy link
Contributor Author

W95Psp commented Feb 14, 2022

Hi, yes, I was surprised too!
I changed the embedding to be sure I'm not breaking anyone's code, but seems like there is no much code that relies on the definition of ident given in ulib's FStar.Reflection.Types module.
@R1kM suggested me to change directly the definition of ident in FStar.Reflection.Types, so that we respect a bit more the ident type from FStar.Ident (which is a record), so I reverted my previous commit and just pushed that modification instead.

@R1kM
Copy link
Collaborator

R1kM commented Feb 14, 2022

As discussed during today's F* meeting, it's unlikely that this was used anywhere since this would lead to the errors you observed. Thanks for the fix and for documenting this in CHANGES.md!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants