Allow --already_cached *,-A,+B,-C
#1711
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, F* namespace arguments to
--already_cached
must be separated with spaces:This may cause issues in such Makefile rules as the following (found in LowParse or miTLS):
This pull request solves (at least) this issue by allowing the user to write
--already_cached *,-A,+B,+C
above, replacing spaces with commas.It works by replacing all spaces with commas, then splitting across commas instead of spaces.
This pull request "collapses" all consecutive commas or spaces into a single one, in fact by removing all empty items returned by
FStar.Util.split
.This pull request is not specific to
--already_cached
, it also impacts--extract
and--using_facts_from
in the same way.(Note: this pull request supersedes #1709, which was allowing arguments with no separator at all, but this was not a future-proof idea in the face of changes in the semantics of
*
,+
or-
)