Add change log #1967
Add change log #1967
Conversation
tools/gen_gm_hsm_node_cert.sh
Outdated
| $SWSSL_CMD req -new -subj "/CN=${name}/O=fisco-bcos/OU=${type}" -key "${certpath}/gm${type}.key" -config "${capath}/gmcert.cnf" -out "${certpath}/gm${type}.csr" 2> /dev/null | ||
| fi | ||
| if [ -n "${no_agency}" ];then | ||
| echo "not use $(basename ${capath}) to sign $(basename ${certpath}) ${type}" >>"${logfile}" |
There was a problem hiding this comment.
[ShellCheck] Double quote to prevent globbing and word splitting. (view)
| Rule | Severity | Code |
|---|---|---|
SC2086 |
info |
2086 |
References:
You can close this issue if no need to fix it. Learn more.
tools/gen_gm_hsm_node_cert.sh
Outdated
| $SWSSL_CMD req -new -subj "/CN=${name}/O=fisco-bcos/OU=${type}" -key "${certpath}/gm${type}.key" -config "${capath}/gmcert.cnf" -out "${certpath}/gm${type}.csr" 2> /dev/null | ||
| fi | ||
| if [ -n "${no_agency}" ];then | ||
| echo "not use $(basename ${capath}) to sign $(basename ${certpath}) ${type}" >>"${logfile}" |
There was a problem hiding this comment.
[ShellCheck] Double quote to prevent globbing and word splitting. (view)
| Rule | Severity | Code |
|---|---|---|
SC2086 |
info |
2086 |
References:
You can close this issue if no need to fix it. Learn more.
tools/gen_gm_hsm_node_cert.sh
Outdated
| generate_script_template() | ||
| { | ||
| local filepath=$1 | ||
| mkdir -p "$(dirname $filepath)" |
There was a problem hiding this comment.
[ShellCheck] Double quote to prevent globbing and word splitting. (view)
| Rule | Severity | Code |
|---|---|---|
SC2086 |
info |
2086 |
References:
You can close this issue if no need to fix it. Learn more.
tools/gen_gm_hsm_node_cert.sh
Outdated
| else | ||
| generate_node_scripts "${output_dir}" | ||
| fi | ||
| if [ ${node_key_type} == "internalKey" ];then |
There was a problem hiding this comment.
[ShellCheck] Double quote to prevent globbing and word splitting. (view)
| Rule | Severity | Code |
|---|---|---|
SC2086 |
info |
2086 |
References:
You can close this issue if no need to fix it. Learn more.
tools/download_swssl.sh
Outdated
| { | ||
| echo "==============================================================" | ||
| LOG_INFO "SWSSL Path : ${HOME}/.fisco/swssl" | ||
| if [[ -n ${hsm_config_array} ]];then |
There was a problem hiding this comment.
[ShellCheck] Expanding an array without an index only gives the first element. (view)
| Rule | Severity | Code |
|---|---|---|
SC2128 |
warning |
2128 |
References:
You can close this issue if no need to fix it. Learn more.
tools/gen_gm_hsm_node_cert.sh
Outdated
| } | ||
|
|
||
| main(){ | ||
| if [ ! -z "$(openssl version | grep reSSL)" ];then |
There was a problem hiding this comment.
[ShellCheck] Use ! grep -q instead of comparing output with [ -z .. ]. (view)
| Rule | Severity | Code |
|---|---|---|
SC2143 |
style |
2143 |
References:
You can close this issue if no need to fix it. Learn more.
tools/download_swssl.sh
Outdated
| case $option in | ||
| o) [ -n "$OPTARG" ] && output_dir="$OPTARG" | ||
| ;; | ||
| H) hsm_config_array=(${OPTARG//,/ });; |
There was a problem hiding this comment.
[ShellCheck] Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. (view)
| Rule | Severity | Code |
|---|---|---|
SC2206 |
warning |
2206 |
References:
You can close this issue if no need to fix it. Learn more.
tools/gen_gm_hsm_node_cert.sh
Outdated
| ;; | ||
| a) agency_key_index=$OPTARG;; | ||
| k) node_key_type=$OPTARG;; | ||
| i) node_key_index=(${OPTARG//,/ });; |
There was a problem hiding this comment.
[ShellCheck] Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. (view)
| Rule | Severity | Code |
|---|---|---|
SC2206 |
warning |
2206 |
References:
You can close this issue if no need to fix it. Learn more.
tools/gen_gm_hsm_node_cert.sh
Outdated
| i) node_key_index=(${OPTARG//,/ });; | ||
| o) output_dir=$OPTARG;; | ||
| X) days="$OPTARG";; | ||
| H) hsm_config_array=(${OPTARG//,/ });; |
There was a problem hiding this comment.
[ShellCheck] Quote to prevent word splitting/globbing, or split robustly with mapfile or read -a. (view)
| Rule | Severity | Code |
|---|---|---|
SC2206 |
warning |
2206 |
References:
You can close this issue if no need to fix it. Learn more.
tools/gen_gm_hsm_node_cert.sh
Outdated
| } | ||
|
|
||
| main(){ | ||
| if [ ! -z "$(openssl version | grep reSSL)" ];then |
There was a problem hiding this comment.
[ShellCheck] Use -n instead of ! -z. (view)
| Rule | Severity | Code |
|---|---|---|
SC2236 |
style |
2236 |
References:
You can close this issue if no need to fix it. Learn more.
Codecov Report
@@ Coverage Diff @@
## release-2.8.0 #1967 +/- ##
================================================
Coverage ? 75.34%
================================================
Files ? 540
Lines ? 45943
Branches ? 0
================================================
Hits ? 34615
Misses ? 11328
Partials ? 0 |
MaggieNgWu
force-pushed
the
newoct
branch
4 times, most recently
from
163c7a6 to
55988a2
Compare
MaggieNgWu
force-pushed
the
newoct
branch
2 times, most recently
from
3cdad8e to
4703ac4
Compare
MaggieNgWu
force-pushed
the
newoct
branch
2 times, most recently
from
4cbd6ef to
d554ac8
Compare
* add CryptoPrecompiled (#1827) * modify keccak256 to keccak256Hash in case of interface conflict (#1834) * disable tcmalloc when DEBUG=on (#1850) * Fix the problem that the codeHash function fails to convert STORAGE_VALUE to h256 (#1858) * get the value of sys_config from the storage (#1870) * Fix the problem of getting CommonName error when matching wrong CN string when parsing agency and node name (#1893) * fix the deadlock problem caused by generatePrepare/notifySeal concurrently after viewchange (#1905) * Check whether the group exists according to the existence of the genesis file (#1907) * fix coredump caused by empty nonce vector (#1912) * Fix leveldb cross-build failed on ARM archtecture platform (#1897) * fix leveldb build faild on ARM platfrom REF: https://github.com/gentoo/gentoo/pull/12745/files Before fix, build on ARM platform, some error will occur, error log: https://gist.github.com/terasum/29b047ba1af1659699a9c11692da347a Co-authored-by: cyjseagull <yujiechen_hust@163.com> Co-authored-by: Xingqang Bai <bxq2011hust@qq.com> Co-authored-by: cyjseagull <1547158861@qq.com> * update evmone and evmc (#1917) * fix build_chain error (#1918) * Add hardware crypto module SDF interface (sync code). (#1921) * add hardware secure module add crypto test tool add sdf sm4 crypto * add sm4 * use condithion compilewq * add sdf option * add sub project SDF * add sm2GetZFromPublicKey function Co-authored-by: Maggie WU <maggie@Maggies-MacBook-Pro.local> * update ProjectSDF url (#1922) * fix build_chain gm multi agency error (#1924) * use constant string to define the consensus type (#1923) * add log show use hardware or software crypto (#1927) * Use hsm-crypto v1.0.0 (#1929) * add log show use hardware or software crypto * rename sdf to hsm * use hsm-crypto v1.0.0 * update hsm-crypto release (#1933) * disable hunter cache (#1937) * correct the path of libswsds.so (#1938) * Remove non ascii test (#1940) * remove non ascii characters test * add sdf sm4 tests * fixe P2PSession circular reference issue (#1941) * Hsm ssl (#1945) * remove non ascii characters test * add sdf sm4 tests * support hsm ssl * modify SecureInitializer.cpp to fix a bug * add #ifdef FISCO_SDF * use WeBankBlockchain/hsm-crypto * update boost version (#1948) * update boost version to 1.76 * fix compile error caused by boost upgradle * fix ut compile error caused by boost upgradle * add build gm hsm chain script (#1950) * add build gm hsm chain script * add multi source of dependencies (#1954) * clear code in libinitializer/SecureInitializer.cpp (#1953) Co-authored-by: Xingqang Bai <bxq2011hust@qq.com> * Fix the problem of memory growth caused by forged P2P message packets (#1958) * add -hsm version suffix (#1959) * remove csmsds.h relay (#1960) * correct project SDF (#1963) * remove csmsds.h relay * correct project SDF * Add download swssl script, and generate gm hsm node script. (#1964) * add download_swssl.sh and gen_gm_hsm_node_cert.sh scripts * fix bug in build_gm_hsm_chain.sh * fix a bug in gen_gm_hsm_node_cert.sh * fix sdf sm4 bug * add double quite in script * Add change log (#1967) * add change log * update sdf url * extend ci no response time to 30m (#1970) * extend to 40min (#1971) Co-authored-by: cyjseagull <yujiechen_hust@163.com> Co-authored-by: Xingqang Bai <bxq2011hust@qq.com> Co-authored-by: cyjseagull <1547158861@qq.com> Co-authored-by: Chen Quan <terasum@163.com> Co-authored-by: Maggie WU <maggie@Maggies-MacBook-Pro.local> Co-authored-by: ywy2090 <912554887@qq.com>
No description provided.