Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] "no data" when finishing game with the webview open #22

Closed
ceselder opened this issue Mar 7, 2024 · 7 comments
Closed

[bug] "no data" when finishing game with the webview open #22

ceselder opened this issue Mar 7, 2024 · 7 comments

Comments

@ceselder
Copy link

ceselder commented Mar 7, 2024

Will reliably show "no data" when finishing ranked games if leaguerecord was open but not in tray. IF it is in tray it behaves as expected.

I know you've been tracking down this bug for a while (I think)? So I hope this helps.

@FFFFFFFXXXXXXX
Copy link
Owner

FFFFFFFXXXXXXX commented Mar 7, 2024

EDIT: nvm, you are saying no data gets saved if the app is open when the game is finished and #23 is about the data showing up late.
Is this specific to ranked games? Because I can't replicate this in a custom game or practicetool game.

I am a little confused what the difference between this and #23 is.
Could you describe the problem a little more?

Currently the recording shows up in the UI as soon as the game ends. The metadata about the game only gets collected as soon as the data is available - which is the same time the post game lobby is ready.

So the intended behaviour looks something like this.
Game starts / no recording in UI -> game ends / recording in UI but no data -> post game lobby is ready / metadata shows up automatically in UI.

Which means if you wait a little the metadata should show up by itself.
Is this not the case?

@ceselder
Copy link
Author

I think it might be specific to ranked games yes. The metadata never shows up however.

@FFFFFFFXXXXXXX
Copy link
Owner

Please enable logs in the settings and post them if it happens again.

I haven't found away to replicate the bug yet.

FFFFFFFXXXXXXX added a commit that referenced this issue Mar 20, 2024
Some stats about the game were deserialized as an u64 but could sometimes be negative.
E.g. negative gold due to the 'Futures Market' rune.

Fix by deserializing values to i64 instead, because it doesn't matter anyways if the valid value ranges are bigger than needed.
@FFFFFFFXXXXXXX
Copy link
Owner

fixed in v1.19.2

@ceselder
Copy link
Author

Thank you so much! What did the bug end up being? (dw if its too logn to explain or you cba)

@FFFFFFFXXXXXXX
Copy link
Owner

It was something stupid.
I was parsing/deserializing the current_gold of the players in the timeline-data to a u64, but it can be negative when a player uses the futures market rune.

I'm think players are way more likely to use futues market in ranked and this was the problem, not the ranked gamemode. And the window open/closed was just coincidental.
But feel free to re-open the issue if I'm wrong and the issue still persists.

@ceselder
Copy link
Author

incredible, thats really funny. Thanks for fixing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants