-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] "no data" when finishing game with the webview open #22
Comments
EDIT: nvm, you are saying no data gets saved if the app is open when the game is finished and #23 is about the data showing up late.
Currently the recording shows up in the UI as soon as the game ends. The metadata about the game only gets collected as soon as the data is available - which is the same time the post game lobby is ready. So the intended behaviour looks something like this. Which means if you wait a little the metadata should show up by itself. |
I think it might be specific to ranked games yes. The metadata never shows up however. |
Please enable logs in the settings and post them if it happens again. I haven't found away to replicate the bug yet. |
Some stats about the game were deserialized as an u64 but could sometimes be negative. E.g. negative gold due to the 'Futures Market' rune. Fix by deserializing values to i64 instead, because it doesn't matter anyways if the valid value ranges are bigger than needed.
fixed in v1.19.2 |
Thank you so much! What did the bug end up being? (dw if its too logn to explain or you cba) |
It was something stupid. I'm think players are way more likely to use futues market in ranked and this was the problem, not the ranked gamemode. And the window open/closed was just coincidental. |
incredible, thats really funny. Thanks for fixing it |
Will reliably show "no data" when finishing ranked games if leaguerecord was open but not in tray. IF it is in tray it behaves as expected.
I know you've been tracking down this bug for a while (I think)? So I hope this helps.
The text was updated successfully, but these errors were encountered: