This repository has been archived by the owner on Nov 9, 2023. It is now read-only.
ESP32: delegate interrupt handling into a separate task #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This frees the handling logic from timing restrictions that could be violated in user code handlers. The ESP32-specific code is wrapped in #define ESP32 in order to preserve old behavior in other architectures. The DW1000 dispatcher task has a priority at least one level higher than the ordinary code (priority 1).
This commit allows the device to temporarily shutdown interrupt handling (if any) so that external code using the library can safely switch over to a different role for the Decawave without resetting.
|
Can you please explain the differences between this and #164 ? Are they trying to achieve the same functionality? |
|
I'll have a look on Saturday. 👍
…On Wed, Aug 19, 2020, 1:45 PM Michele Biondi ***@***.***> wrote:
@zrecore <https://github.com/zrecore> Are you available to try out these
improvements (this and #177
<#177>) ? Thank you
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#178 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADIW3G42D4NGCHEUNIPVQ3SBQ2XNANCNFSM4P5M42DA>
.
|
It seems that #164 has the same purpose as my commit. However, my version does not change the library API, and since the task has a higher priority than the ordinary code, it should be less prone to handling delays. |
Merged
|
We are closing pull requests with merging conflicts as we are archiving the repo, feel free to create your own fork if you intend to support the project, we will be happy to add a link on this project. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request switches the interrupt request handling from a direct ISR into a separate task. This allows the handler more flexibility in how to handle the interrupt, without violating timing limits that may cause lockups or watchdog reboots. For platforms other than ESP32, the behavior of the code has been preserved.